search

ManageIQ / manageiq-providers-kubevirt

ManageIQ plugin for the Kubevirt provider.
https://kubevirt.io/
Apache License 2.0
4 stars 29 forks source link

Add a rubocop channel to the codeclimate config #145

Closed djberg96 closed 5 years ago

djberg96 commented 5 years ago

Add a rubocop channel to the codeclimate config

miq-bot commented 5 years ago

Checked commit https://github.com/djberg96/manageiq-providers-kubevirt/commit/adfa828a9bc625952a5860087f2e7f7449a47bc1 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 0 files checked, 0 offenses detected Everything looks fine. :cake:

agrare commented 5 years ago

@djberg96 any idea why codeclimate is still failing on rubocop-performance? https://codeclimate.com/github/ManageIQ/manageiq-providers-kubevirt/pull/145

djberg96 commented 5 years ago

@agrare Are we being mislead? If you click on "view the build" for the link you provided, it takes you to https://codeclimate.com/github/ManageIQ/manageiq-providers-kubevirt/builds/562 which is NOT this build.

This one should be https://codeclimate.com/github/ManageIQ/manageiq-providers-kubevirt/builds/559, which is green.

agrare commented 5 years ago

Oh that is weird, codeclimate bug I guess?

djberg96 commented 5 years ago

@agrare Looks like it to me. I've put in a support request. It's up to you if you want to wait, or just merge it and ignore the failure.

agrare commented 5 years ago

No this looks good to me