search

ManageIQ / manageiq-providers-kubevirt

ManageIQ plugin for the Kubevirt provider.
https://kubevirt.io/
Apache License 2.0
4 stars 29 forks source link

Update fog-kubevirt to newer version #160

Closed agrare closed 4 years ago

agrare commented 4 years ago

Allow for the use of a newer version of kubeclient by bumping fog-kubevirt

masayag commented 4 years ago

Hi @agrare

I think that further changes are required: The namespace was changed as well when we fog-kubevirt was bumped to support fog-code > 2.0

https://github.com/fog/fog-kubevirt/pull/23

agrare commented 4 years ago

:+1: thanks yeah just saw the test failures

Trying to get on a newer version of kubeclient which is what prompted this

miq-bot commented 4 years ago

Checked commit https://github.com/agrare/manageiq-providers-kubevirt/commit/7801837569742456c5acc7d598a2663915d4acfd with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint 2 files checked, 1 offense detected

app/models/manageiq/providers/kubevirt/infra_manager/connection.rb

agrare commented 4 years ago

Thanks @masayag !

agrare commented 4 years ago

Backport depends on https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/368

simaishi commented 4 years ago

Jansa backport details:

$ git log -1
commit 45d4b13928e9c9b21ab315e38a74058a8c8f3f3b
Author: Moti Asayag <masayag@redhat.com>
Date:   Mon Apr 20 19:19:22 2020 +0300

    Merge pull request #160 from agrare/bump_fog_kubevirt

    Update fog-kubevirt to newer version

    (cherry picked from commit 91ae48caf10794864ba79642c888642e3310a581)