search

ManageIQ / manageiq-providers-kubevirt

ManageIQ plugin for the Kubevirt provider.
https://kubevirt.io/
Apache License 2.0
4 stars 29 forks source link

BigDecimal#initialize was removed in 2.0.0 #161

Closed agrare closed 4 years ago

agrare commented 4 years ago

Move to BigDecimal(value) instead of BigDecimal.new(value) as this was removed and no longer works on recent rubies (https://github.com/ruby/bigdecimal/blob/master/CHANGES.md#200)

https://github.com/ManageIQ/manageiq/issues/19678

miq-bot commented 4 years ago

Checked commit https://github.com/agrare/manageiq-providers-kubevirt/commit/f8e4396ae94e5e7b1cee3b4a8da1e96dda9b9592 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :star:

agrare commented 4 years ago

Thanks for the review @masayag this is green now