search

ManageIQ / manageiq-providers-kubevirt

ManageIQ plugin for the Kubevirt provider.
https://kubevirt.io/
Apache License 2.0
4 stars 29 forks source link

Skip Openshift non-VM Templates in kubevirt #204

Closed agrare closed 2 years ago

agrare commented 2 years ago

The fog-kubevirt gem is returning all Openshift Templates and we need to only process ones which have an embedded vm object

Here is an example of a Template that isn't a VM template

(byebug) object
  <Fog::Kubevirt::Compute::Template
    name="3scale-gateway",
    namespace="openshift",
    description="3scale's APIcast is an NGINX based API gateway used to integrate your internal and external API services with 3scale's API Management Platform. It supports OpenID connect to integrate with external Identity Providers such as Red Hat Single Sign On, for API traffic authentication",
    tags="api,gateway,3scale",
    labels={:"samples.operator.openshift.io/managed"=>"true"},
    resource_version="16410",
    uid="5d21a2a9-9533-4fff-9fc9-5e3d3a50827d"
miq-bot commented 2 years ago

Checked commit https://github.com/agrare/manageiq-providers-kubevirt/commit/43544ade724d4d6e9a8d249282d1c8b876f9a67f with ruby 2.6.7, rubocop 1.19.1, haml-lint 0.35.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :trophy:

Fryguy commented 2 years ago

Backported to najdorf in commit fef6d55ae92b7a109e59a5899daaa32b6f20a37b.

commit fef6d55ae92b7a109e59a5899daaa32b6f20a37b
Author: Jason Frey <fryguy9@gmail.com>
Date:   Wed Mar 2 12:19:19 2022 -0500

    Merge pull request #204 from agrare/fix_non_vm_templates

    Skip Openshift non-VM Templates in kubevirt

    (cherry picked from commit 2ec48b7d0a0fc775deed9edba594f531de5b6145)