Closed jrafanie closed 2 years ago
Is this something we should put in all of the providers? Perhaps at the provider generator level? Or perhaps in core in a pluggable manner? cc @agrare
Removed najdorf/yes? as we are not backporting anything Rails 6.1
Yeah I see a number of providers have spec/fixtures
:
manageiq-providers-amazon/spec/fixtures:
orchestration_templates
manageiq-providers-azure/spec/fixtures:
events orchestration_templates
manageiq-providers-azure_stack/spec/fixtures:
orchestration_templates
manageiq-providers-kubevirt/spec/fixtures:
files
manageiq-providers-openstack/spec/fixtures:
orchestration_templates
manageiq-providers-vmware/spec/fixtures:
orchestration_templates
I'm assuming all of these would have to be updated?
As for the generator, if spec/fixtures
aren't used we probably don't need this...or should we create an empty spec/fixtures
dir just in case?
I don't really understand the spec/fixtures... I didn't think we used fixtures at all
Yeah I see a number of providers have
spec/fixtures
:manageiq-providers-amazon/spec/fixtures: orchestration_templates manageiq-providers-azure/spec/fixtures: events orchestration_templates manageiq-providers-azure_stack/spec/fixtures: orchestration_templates manageiq-providers-kubevirt/spec/fixtures: files manageiq-providers-openstack/spec/fixtures: orchestration_templates manageiq-providers-vmware/spec/fixtures: orchestration_templates
These aren't failing on cross repo so I wonder if the problem is that this one uses a non-standard path: "spec/fixtures/files"
Others seem to use spec/fixtures/...
And yet more just build their own path and don't use fixture_path at all: https://github.com/ManageIQ/manageiq-providers-vmware/blob/7e78afd5da4e05364156801408df06e57f56a896/spec/factories/orchestration_template.rb#L5
I didn't think we used fixtures at all
Yeah to be honest this is the first I've seen these
I wonder if the problem is that this one uses a non-standard path
Oh interesting
As of https://github.com/ManageIQ/manageiq/pull/22039 core now specifies the fixture path so we need to be explicit when running these tests.