search

ManageIQ / manageiq-providers-kubevirt

ManageIQ plugin for the Kubevirt provider.
https://kubevirt.io/
Apache License 2.0
4 stars 29 forks source link

Openshift Virtualization subclassing changes #247

Closed nasark closed 1 month ago

nasark commented 2 months ago

Depends on:

@miq-bot assign @agrare @miq-bot add_label enhancement @miq-bot add_reviewer @agrare

Fryguy commented 2 months ago

@nasark Can you just clean up the handful of rubocops from the bot?

miq-bot commented 2 months ago

Checked commit https://github.com/nasark/manageiq-providers-kubevirt/commit/c61ad6dafbed167722c18bfe1b0dca65ed749fad with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 4 files checked, 0 offenses detected Everything looks fine. :cake:

miq-bot commented 2 months ago

Checked commit https://github.com/nasark/manageiq-providers-kubevirt/commit/c61ad6dafbed167722c18bfe1b0dca65ed749fad with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 4 files checked, 0 offenses detected Everything looks fine. :cookie:

nasark commented 2 months ago

@agrare I'll take note of follow-ups for a future PR

Fryguy commented 3 weeks ago

Backported to radjabov in commit 75e8a49624ecea5023a96df1ac239bdd49c607e6.

commit 75e8a49624ecea5023a96df1ac239bdd49c607e6
Author: Adam Grare <adam@grare.com>
Date:   Tue Sep 10 11:36:41 2024 -0400

    Merge pull request #247 from nasark/osv_subclassing

    Openshift Virtualization subclassing changes

    (cherry picked from commit f19073a7c2784d7b11b4b2b7b7eb604f627db44e)