Fix Kubevirt client get resource by name calls

[nasark]

• resource.get(name) calls are namespace scoped
• since we use the catch-all namespace "" when initializing the client https://github.com/ManageIQ/manageiq-providers-kubevirt/blob/master/app/models/manageiq/providers/kubevirt/infra_manager.rb#L126, this will work for resource.all calls but will not work for resource.get(name) calls i.e. https://github.com/fog/fog-kubevirt/blob/master/lib/fog/kubevirt/compute/requests/get_template.rb#L6 and will return a 404

Fixes https://github.com/ManageIQ/manageiq-providers-kubevirt/issues/241

@miq-bot assign @agrare @miq-bot add_label bug, radjabov/yes? @miq-bot add_reviewer @agrare

[agrare]

@nasark if you had two templates with the same name in two namespaces would this reliably find the right one?

[nasark]

@nasark if you had two templates with the same name in two namespaces would this reliably find the right one?

@agrare Good point, .find would return the first template that meets the criteria in the list which is not good. I guess another option is to add a provisioning option to specify the namespace of a template, then we wouldn't need these changes

[agrare]

Yeah so since we've selected a template already we should know the namespace, is the ns part of the miq_template record at all?

[nasark]

@agrare There is a location column but all the templates have values "unknown"

3.0.1 :003 > template = MiqTemplate.find_by(:name => "fedora-server-small")
 => 
#<ManageIQ::Providers::Openshift::InfraManager::Template:0x000000010f275fc8
... 
3.0.1 :004 > template.location
 => "unknown" 

https://github.com/ManageIQ/manageiq-providers-kubevirt/blob/master/app/models/manageiq/providers/kubevirt/inventory/parser.rb#L202 - is this correct? We could easily set this to the namespace since its returned by the client

[agrare]

Interesting, if the template object from kubevirt has a namespace we should set that in the location just like vms do

[Fryguy]

Backported to radjabov in commit faaee45d71c921a7f2bd97e8bcd0a2cd76405eb6.

commit faaee45d71c921a7f2bd97e8bcd0a2cd76405eb6
Author: Adam Grare <adam@grare.com>
Date:   Mon Sep 23 15:10:26 2024 -0400

    Merge pull request #249 from nasark/kubevirt_service_catalog_provisioning

    Fix Kubevirt client get resource by name calls

    (cherry picked from commit 389a4937c4e835c608f11cff7568359415636b3b)