ManageIQ / manageiq-providers-kubevirt

ManageIQ plugin for the Kubevirt provider.
https://kubevirt.io/
Apache License 2.0
4 stars 29 forks source link

Service Catalog Provisioning Support #250

Closed nasark closed 1 month ago

nasark commented 1 month ago

Needed for:

@miq-bot assign @agrare @miq-bot add_labels bug, radjabov/yes? @miq-bot add_reviewer @agrare

nasark commented 1 month ago

Fixed

WIP need to iron out the catalog provisioning dialog, currently seeing this

Screenshot 2024-09-11 at 3 04 23 PM
[----] F, [2024-09-11T15:43:23.034306 #74896:f5bf4] FATAL -- : Error caught: [NoMethodError] undefined method `sort_by' for nil:NilClass
/Users/nasarkhan/.rvm/gems/ruby-3.0.1/bundler/gems/manageiq-ui-classic-e3829c0aa36e/app/controllers/application_controller/miq_request_methods.rb:359:in `_build_whatever_grid'
/Users/nasarkhan/.rvm/gems/ruby-3.0.1/bundler/gems/manageiq-ui-classic-e3829c0aa36e/app/controllers/application_controller/miq_request_methods.rb:447:in `build_vc_grid'
/Users/nasarkhan/.rvm/gems/ruby-3.0.1/bundler/gems/manageiq-ui-classic-e3829c0aa36e/app/controllers/application_controller/miq_request_methods.rb:541:in `build_grid'
/Users/nasarkhan/.rvm/gems/ruby-3.0.1/bundler/gems/manageiq-ui-classic-e3829c0aa36e/app/controllers/application_controller/miq_request_methods.rb:30:in `prov_field_changed'

Seems like I need to specify either :allowed_customization_templates or :sysprep_custom_spec keys in the provisioning yaml https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/application_controller/miq_request_methods.rb#L538-L542 but not sure if those are relevant to the changes this PR is trying to achieve

nasark commented 1 month ago

@agrare Ready for review

agrare commented 1 month ago

Okay I found a number of other issues which I've opened PRs for but I was able to provision a VM from a template with this and https://github.com/ManageIQ/manageiq-providers-openshift/pull/266 applied

Fryguy commented 3 weeks ago

Backported to radjabov in commit f7740ed4f4ed139fc99296a16b416fa4bb03d7da.

commit f7740ed4f4ed139fc99296a16b416fa4bb03d7da
Author: Adam Grare <adam@grare.com>
Date:   Wed Sep 25 13:15:50 2024 -0400

    Merge pull request #250 from nasark/kubevirt_service_catalog_provisioning_v2

    Service Catalog Provisioning Support

    (cherry picked from commit 114a3985d29c3d9c82fa0222c93393fa1fcf2f75)