search

ManageIQ / manageiq-providers-nsxt

ManageIQ plugin for the VMware NSX-T provider.
Apache License 2.0
2 stars 20 forks source link

Warning in create-nsxt-security-group-form.jsx #45

Open Fryguy opened 3 years ago

Fryguy commented 3 years ago

Noticed the following in the browser console:

unreachable code after return statement   create-nsxt-security-group-form.jsx:79:4,

which points to https://github.com/ManageIQ/manageiq-providers-nsxt/blob/d0c7629b7b3f72d46f13694b12ed10f05b5fac11/app/javascript/components/security-groups/create-nsxt-security-group-form.jsx#L79

cc @kavyanekkalapu

kavyanekkalapu commented 2 years ago

@Fryguy I cloned this repo and added in my local plugins. Any idea where i can see this page in UI. I went to create security group page but nsxt provider is not showing up in providers at all/

chessbyte commented 2 years ago

@agrare ^^

agrare commented 2 years ago

That file was created by https://github.com/ManageIQ/manageiq-providers-nsxt/pull/8 when refactoring to DDF, before it was /components/security-groups/create-nsxt-security-group-form-provider [ref]

I can't help you much with where in the UI this is called from, but from the name I assume it is creating a security group. Maybe follow the commit history? Could be something got refactored and it is no longer needed, I don't know

kavyanekkalapu commented 2 years ago

This component being used in

https://github.com/ManageIQ/manageiq-providers-nsxt/blob/c7b0fb5bae1b99c64740d2c6cb3614716a1b67ff/app/helpers/helper/manageiq/providers/nsxt/toolbar_overrides/security_groups_center.rb#L26

. I am not seeing the nsx provider in list at all. Screen Shot 2021-10-04 at 9 09 06 PM

@agrare these visible in provider summary page if i create a valid nsx provider?

kavyanekkalapu commented 2 years ago

Recently i remember looking at the pr in ibm cloud provider (https://github.com/ManageIQ/manageiq-providers-ibm_cloud/blob/531473e045ea9ecf8e3e8da0c0492c6198abafe4/app/helpers/manageiq/providers/ibm_cloud/toolbar_overrides/ems_cloud_center.rb). This dialog opened up in IBM provider summary page.

miq-bot commented 1 year ago

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.