search

ManageIQ / manageiq-providers-openstack

ManageIQ plugin for the OpenStack provider.
https://www.openstack.org/
Apache License 2.0
12 stars 91 forks source link

Fix Gem.loaded_specs looking for wrong key name #863

Closed agrare closed 11 months ago

agrare commented 11 months ago

Gem.loaded_specs has string keys which was causing this check to always return false

(byebug) Gem.loaded_specs.key?(:qpid_proton)
false
(byebug) Gem.loaded_specs.key?("qpid_proton")
true
agrare commented 11 months ago

Found while testing https://github.com/ManageIQ/manageiq-providers-nuage/pull/299

jrafanie commented 11 months ago

Wow, nice find @agrare. I wonder when this changed.

Fryguy commented 11 months ago

Backported to quinteros in commit e210b4f3e77482e09f2ae88f04c87498a957ddc0.

commit e210b4f3e77482e09f2ae88f04c87498a957ddc0
Author: Joe Rafaniello <jrafanie@users.noreply.github.com>
Date:   Mon Oct 30 13:44:05 2023 -0400

    Merge pull request #863 from agrare/fix_gem_loaded_specs_qpid_proton_key

    Fix Gem.loaded_specs looking for wrong key name

    (cherry picked from commit ff466c29c9855f0854ea8a1087033232149ebbe5)