drop use of unuspported_reason_add

[kbrock]

@agrare please take a look at this one. The patterns are different from the other providers

feels like a number of these could just delegate the reason to the failed supports check

---

part of:

• https://github.com/ManageIQ/manageiq/pull/22898

Deprecating unsupported_reason_add. Returning the string instead

Note, these are all the same:

unsupported_reason_add(:feature, unsupported_reason(:feature2)) unless supports_feature2?
unsupported_reason_add(:feature, unsupported_reason(:feature2)) unless supports?(:feature2)
unsupported_reason(:feature2) unless supports?(:feature2)
unsupported_reason(:feature2)

[kbrock]

update:

• fixed extra paren and missing || (rubocop called an indent)

looks like miq-bot did not pickup change

[kbrock]

update:

• fixed action(:control)
• swapped remove_snapshot_denied_message => supports :remove_snapshot per vm_snapshot_remove_one.rb

From what I could tell, :remove_snapshot is not used

update:

• removed fixes for remove_snapshot back to just unsupported_reason_add or check_feature_support

[miq-bot]

Some comments on commits https://github.com/kbrock/manageiq-providers-ovirt/compare/180a51ed6799e51fe1cbe0e4d4840e3b9f156f95~...582205b748ca38b2a1d025b95cb418dc9975497b

https://github.com/ManageIQ/manageiq-providers-ovirt/commit/582205b748ca38b2a1d025b95cb418dc9975497b

• [ ] :grey_exclamation: - Username @active detected in commit message. Consider removing.

[miq-bot]

Checked commits https://github.com/kbrock/manageiq-providers-ovirt/compare/180a51ed6799e51fe1cbe0e4d4840e3b9f156f95~...582205b748ca38b2a1d025b95cb418dc9975497b with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 8 files checked, 0 offenses detected Everything looks fine. :trophy: