search

ManageIQ / manageiq-providers-vmware

ManageIQ plugin for the VMware vSphere and vCloud providers.
Apache License 2.0
22 stars 70 forks source link

Introducing params_for_update schema to Hosts #851

Closed MelsHyrule closed 1 year ago

MelsHyrule commented 1 year ago

Introducing credential endpoints for host. Found only this for endpoint validation.

Part of https://github.com/ManageIQ/manageiq-ui-classic/pull/8608

kbrock commented 1 year ago

so for vmware, we are only doing web services password? and not doing the ssh version?

I was expecting to see 3 forms in here.

ESX hosts have ws support, but the regular host only has ssh. (ipmi is going away) [ref]

    case auth_type.to_s
    when 'remote' then verify_credentials_with_ssh(auth_type, options)
    when 'ws'     then verify_credentials_with_ws(auth_type)
    when 'ipmi'   then verify_credentials_with_ipmi(auth_type)
MelsHyrule commented 1 year ago

@kbrock I didn't notice that method during my first pass of these files, ill add in the remote/ssh fields now

miq-bot commented 1 year ago

Checked commit https://github.com/MelsHyrule/manageiq-providers-vmware/commit/8fb08f0d81370a85b9f1d65479392b331fadf92d with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :star: