ManageIQ / manageiq-providers-vmware

ManageIQ plugin for the VMware vSphere and vCloud providers.
Apache License 2.0
22 stars 70 forks source link

Converge batch_size and concurrent_requests #870

Closed kbrock closed 1 year ago

kbrock commented 1 year ago

part of: https://github.com/ManageIQ/manageiq/pull/22510

Before

After

Reason for change

While batch_size may be 250, concurrent_requests was then applied and we were sending only 20 requests for realtime and 1 for historical.

So in the end, we only are sending 1 request to the provider. The optimization has basically been disabled.

This gives better values for concurrent requests, and matches the requests sent to the collector over the queue and from the collector to the provider

This requires changes in both vmware and core.

NOTE: these values are estimates and have not been battle tested in production. They are better than the current values though (read: 1)

miq-bot commented 1 year ago

Checked commit https://github.com/kbrock/manageiq-providers-vmware/commit/cca8a80d93f42f21560187faaf237bdd45bb97bb with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :star:

kbrock commented 1 year ago

failure: depends upon change in master

agrare commented 1 year ago

I was waiting on a schema PR being opened and totally missed that @kbrock put one in two days ago