Defer metrics collection batching to queue

ManageIQ / manageiq-providers-vmware

ManageIQ plugin for the VMware vSphere and vCloud providers.

Apache License 2.0

22 stars 70 forks source link

Defer metrics collection batching to queue #871

Closed kbrock closed 1 year ago

kbrock commented 1 year ago

followup to #870 Fixes master build on core

Before

Core partitions the metrics collection work and putting them onto the queue. Vmware then double checks the work, adding partitioning. This is unnecessary and in the process, overriding the concurrent_requests value confuses core when it slices up the metrics collector requests.

After

Vmware is now expecting the queue messages to be pre-partitioned. So no extra work is done here.

kbrock commented 1 year ago

@miq-bot cross-repo-tests /core

kbrock commented 1 year ago

update:

perf_query: changed to _interval_name

update:

perf_query: dropped interval_name

miq-bot commented 1 year ago

Checked commit https://github.com/kbrock/manageiq-providers-vmware/commit/fadcca00fb084ddb707086cda60eb46fb1686e34 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :star: