search

ManageIQ / manageiq-providers-vmware

ManageIQ plugin for the VMware vSphere and vCloud providers.
Apache License 2.0
22 stars 70 forks source link

Add supports storage smartstate_analysis #887

Closed nasark closed 8 months ago

nasark commented 11 months ago

Core has been changed to use supports_not and since vmware is the only provider that supports storage scans this is needed here

@miq-bot add_label bug @miq-bot assign @agrare

agrare commented 10 months ago

@nasark We're dropping the supports :smartstate_analysis from ::Storage base class (nice) but I think we need to add it here to the Vmware::InfraManager::Storage

nasark commented 8 months ago

@miq-bot add_label quinteros/yes?

miq-bot commented 8 months ago

Checked commit https://github.com/nasark/manageiq-providers-vmware/commit/573100d52343f6bb8781f42af85c7354e7090c0a with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :trophy:

Fryguy commented 8 months ago

Backported to quinteros in commit 624712bb3ee83faaba4ef0d23cc0d10aa2fe8320.

commit 624712bb3ee83faaba4ef0d23cc0d10aa2fe8320
Author: Adam Grare <adam@grare.com>
Date:   Tue Jan 2 11:48:10 2024 -0500

    Merge pull request #887 from nasark/add_supports_storage_smartstate_analysis

    Add supports storage smartstate_analysis

    (cherry picked from commit 1c737166c05a0b56f653218a3c1431214b12888e)