Fix Host default_authentication_type

[agrare]

As part of the Host Edit Form React Conversion (https://github.com/ManageIQ/manageiq-ui-classic/pull/8608) we changed how host credentials were saved.

Previously we were using https://github.com/ManageIQ/manageiq-ui-classic/pull/8608/files#diff-2f9b6ee0650a1df116a5ec2bc289814be20808a8107e27fd15cffc2394ad416aL199 which set the :default authentication type.

Now as of https://github.com/ManageIQ/manageiq-providers-vmware/pull/851 and https://github.com/ManageIQ/manageiq-providers-vmware/pull/859 the authentication type being set is "ws".

This causes issues with host.authentication_status_ok? (which is used by SSA https://github.com/ManageIQ/manageiq/blob/master/app/models/vm_or_template.rb#L991) because it is looking for a :default authentication.

NOTE we will have upgrade scenarios where existing hosts will have "default" authentication records, we'll need to resolve this likely with a data migration.

[kbrock]

Personal notes:

In https://github.com/ManageIQ/manageiq/pull/22336 we changed the authentication types so we did not have to copy/paste the same code in all child providers. I was concerned that this introduced the bug.

In that code, we leveraged default authentication type. Before the change, the code defaulted the authentication to :ws - which was strange since only vmware implemented :ws. I(?) later added the default concept so we could remove more providers overwriting the code.

But @agrare is suggesting that it may be only loosely related.

I agree with this direction:

• add a migration to convert all vmware from ws to default.
• lets drop the ws concept. I could only find in 3 blocks of code:
  • https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/host_controller.rb#L306
  • https://github.com/ManageIQ/manageiq-providers-vmware/blob/master/app/models/manageiq/providers/vmware/infra_manager/vim_connect_mixin.rb#L5
  • https://github.com/kbrock/manageiq-ui-classic/blob/master/spec/controllers/host_controller_spec.rb#L425

[agrare]

I think even though this will require a data migration to truly fix, we should probably backport this because otherwise there is no way to add host credentials for host-based SSA scanning. We could doc that the user has to re-enter the credentials after upgrading to this version in a patch release

[agrare]

I'm going to mark as WIP pending some more testing with the latest commit

[miq-bot]

Checked commits https://github.com/agrare/manageiq-providers-vmware/compare/879a964e873c31de5b5af14e3171a155cd119314~...db0f71478c11147cca926bab5bd5b6c4380f59df with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 2 files checked, 0 offenses detected Everything looks fine. :star:

[agrare]

Okay I've tested adding creds with the "default" type and checked that doing a host ssa scan will use this authentication when it connects.

[agrare]

Taking out of WIP