drop unsupported_reason_add

ManageIQ / manageiq-providers-vmware

ManageIQ plugin for the VMware vSphere and vCloud providers.

Apache License 2.0

22 stars 70 forks source link

drop unsupported_reason_add #901

Closed kbrock closed 6 months ago

kbrock commented 6 months ago

part of:

https://github.com/ManageIQ/manageiq/pull/22898

Deprecating unsupported_reason_add. Returning the string instead

Note, these are all the same:

unsupported_reason_add(:feature, unsupported_reason(:feature2)) unless supports_feature2?
unsupported_reason_add(:feature, unsupported_reason(:feature2)) unless supports?(:feature2)
unsupported_reason(:feature2) unless supports?(:feature2)
unsupported_reason(:feature2)

kbrock commented 6 months ago

I put the redundant return because it was more consistent

miq-bot commented 6 months ago

Checked commit https://github.com/kbrock/manageiq-providers-vmware/commit/cf716a59e1297337eab171bd39635be423334f3d with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 10 files checked, 1 offense detected

app/models/manageiq/providers/vmware/infra_manager/host_esx.rb

[ ] :exclamation: - Line 223, Col 5 - Style/RedundantReturn - Redundant return detected.

kbrock commented 6 months ago

update:

localization x 4 (_())
control(:feature) => if else