search

ManageIQ / manageiq-providers-vmware

ManageIQ plugin for the VMware vSphere and vCloud providers.
Apache License 2.0
22 stars 70 forks source link

Fix VM Provision datastore location class #911

Closed agrare closed 3 months ago

agrare commented 3 months ago

When building the VirtualMachineRelocateSpec the datastore property is a ManagedObjectReference to a Datastore. We were setting the value to a simple String rather than a VimString with the proper xsiType/vimType.

This would have broken when we moved from having VimString in ems_ref as a serialized yaml column and added ems_ref_obj.

This causes the clone to fail when using a vcsim (https://github.com/vmware/govmomi/tree/main/vcsim)

Depends on:

agrare commented 3 months ago

NOTE this is failing because the storage_vmware factory doesn't have the proper class set so we don't have the ems_ref_obj method defined.

miq-bot commented 3 months ago

Checked commit https://github.com/agrare/manageiq-providers-vmware/commit/b8e8f34dfe143ca7d0d5c174ed0e604b9adfff11 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 2 files checked, 0 offenses detected Everything looks fine. :+1: