search

ManageIQ / manageiq-schema

SQL schema and database migrations for ManageIQ
Apache License 2.0
20 stars 126 forks source link

remove CINDER storage object #186

Closed lpichler closed 5 years ago

lpichler commented 6 years ago

Based on discussing with @himdel and @hstastna we found that support for Storage object with store_type = CINDER has been removed.

So we need to remove such objects from DB with migration.

I believe that query to determine what to remove is Storage.where(:store_type => 'CINDER') @himdel is it enough ?

Links

After discussion in https://github.com/ManageIQ/manageiq-ui-classic/issues/3742

UI related issue: https://github.com/ManageIQ/manageiq-ui-classic/issues/3743

Screenshot

(highlighted is object to remove for example)

himdel commented 6 years ago

Also swift :)

Fryguy commented 6 years ago

@roliveri Can you comment on this?

roliveri commented 6 years ago

As far as I know, they both should still be supported. What makes you believe they are not? Is this just from a "datastore" point of view - storage where VM files reside? Because Cinder and Swift storage objects are still collected.

@jerryk55 @hsong-rh Do we put anything in the storages table?

jerryk55 commented 6 years ago

I don't believe we do. I think this is just datastores. Regardless I'm not sure why we would be removing these.

himdel commented 6 years ago

Ok, maybe there's been some confusion here..

"ontap" was supposed to be removed, right? ("ontap_storage_system", "ontap_logical_disk", "cim_base_storage_extent", "ontap_storage_volume", "ontap_file_share", "snia_local_file_system")

I don't really understand the relationship between the two, but after that, it looked like EmsSwift, EmsCinder and EmsStorage are dead code, which led to https://github.com/ManageIQ/manageiq-ui-classic/pull/2988. (Turns out, EmsStorage was not dead so that part got reverted later.)

But.. if EmsCinder and EmsSwift are not supposed to be dead, where in the UI should we be seeing those?

jerryk55 commented 6 years ago

Yes "ontap" should be nuked. I'm not sure why EmsSwift and EmsCinder are dead. I'll take a look...

miq-bot commented 5 years ago

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

JPrause commented 5 years ago

@jerryk55 is this still a valid issue? If yes, please remove the stale label. If not can you close. If there's no update by next week, I'll be closing this issue.

JPrause commented 5 years ago

Closing issue. If you feel the issue needs to remain open, please either reopen or let me know and it will be reopened. @miq-bot close_issue