Fix MiqWin32::Software.DecodeProductKey

Fryguy commented 4 years ago

@chessbyte Please review.

I noticed this when going through the manageiq-gems-pending removals, and stumbled on https://github.com/ManageIQ/manageiq-gems-pending/pull/472. However the search in that PR was incorrect as it wasn't searching the whole org. When I searched the whole org I noticed these 2 callers of base24Decode.

This PR puts the base24_decode code back, and then fixes the callers which were actually broken, adding specs along the way.

Fryguy commented 4 years ago

We've likely not seen this in production because the rescue was catching the missing method and then just moving on.

miq-bot commented 4 years ago

Checked commits https://github.com/Fryguy/manageiq-smartstate/compare/3fea192dc2bf595ade9267a089acfdc30a930956~...8cb311564eb0a8bc1670945200f26cd73816b986 with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint 5 files checked, 2 offenses detected

lib/manageiq/smartstate/util.rb

[ ] :exclamation: - Line 18, Col 18 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].

spec/metadata/util/win32/Win32Software_spec.rb

[ ] :exclamation: - Line 1, Col 1 - Naming/FileName - The name of this source file (Win32Software_spec.rb) should use snake_case.

ManageIQ / manageiq-smartstate

Fix MiqWin32::Software.DecodeProductKey #145