Remove ems_*/show

[miq-bot]

The ems_*/show.html.haml templates were removed in https://github.com/ManageIQ/manageiq/pull/10154, because they should not be needed.

However, to fix https://bugzilla.redhat.com/show_bug.cgi?id=1381162 (and a few other bugs probably), they were reintroduced in https://github.com/ManageIQ/manageiq/pull/11822.

They need to be removed again, once there's no render :action => "show" in ApplicationController.

Cc: @martinpovolny

---

This issue was moved to this repository from https://github.com/ManageIQ/manageiq/issues/11821, originally opened by @himdel

[himdel]

(IIRC @martinpovolny is working on this..)

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

[JPrause]

@martinpovolny is this still a valid issue? If yes, lease remove the stale label. If not can you close. If there's no update by next week, I'll be closing this issue.

[JPrause]

Closing issue. If you feel the issue needs to remain open, please either reopen or let me know and it will be reopened. @miq-bot close_issue

[JPrause]

@miq-bot remove_label stale

[gtanzillo]

Ping @h-kataria to see if this has been done

[h-kataria]

@JunyiSun Can you please take a look at this, it looks like that it is safe to remove the ems_*/show.html.haml views. Please make sure to test it from different screens in UI. Test scenarios similar to the one given below from the BZ mentioned in the main comment of this PR

Steps to Reproduce:
1.Navigate to any Infra provider summary page.
2.click on cluster, select few clusters and  from configuration compare selected items.
3.

Similarly compare for host, vm and templates.

Actual results:
Missing template ems_infra/show, application/show with {:locale=>[:en], :formats=>[:html], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby, :coffee, :haml, :jbuilder, :rjs]}. Searched in: * "/var/www/miq/vmdb/app/views" * "/opt/rh/rh-ruby23/root/usr/share/gems/gems/redhat_access_cfme-1.1.0/app/views" [ems_infra/compare_miq]. see attached screenshot

Expected results:
comparison successful

Additional info:
production.log
[----] I, [2016-10-03T05:42:37.442571 #11819:e68c50]  INFO -- : Processing by EmsInfraController#button as JS
[----] I, [2016-10-03T05:42:37.442759 #11819:e68c50]  INFO -- :   Parameters: {"miq_grid_checks"=>"1,2", "pressed"=>"ems_cluster_compare", "id"=>"1"}
[----] I, [2016-10-03T05:42:37.474841 #11819:e68c50]  INFO -- : Completed 200 OK in 32ms (Views: 1.1ms | ActiveRecord: 0.0ms)
[----] I, [2016-10-03T05:42:37.709268 #11800:3e8940c]  INFO -- : Finished "/ws/notifications" [WebSocket] for 127.0.0.1 at 2016-10-03 05:42:37 -0400
[----] E, [2016-10-03T05:42:37.709831 #11800:3e8940c] ERROR -- : There was an exception - NoMethodError(undefined method `fetch' for nil:NilClass)
[----] E, [2016-10-03T05:42:37.710043 #11800:3e8940c] ERROR -- : /opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/server/configuration.rb:24:in `pubsub_adapter'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/server/base.rb:72:in `block in pubsub'
/opt/rh/rh-ruby23/root/usr/share/ruby/monitor.rb:214:in `mon_synchronize'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/server/base.rb:72:in `pubsub'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/connection/base.rb:52:in `pubsub'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/channel/streams.rb:112:in `pubsub'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/channel/streams.rb:106:in `block in stop_all_streams'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/channel/streams.rb:105:in `each'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/channel/streams.rb:105:in `stop_all_streams'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:382:in `block in make_lambda'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:242:in `block in simple'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:456:in `block in call'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:456:in `each'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:456:in `call'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:448:in `block (2 levels) in around'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:286:in `block (2 levels) in halting'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/execution_wrapper.rb:72:in `wrap'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/engine.rb:66:in `block (3 levels) in <class:Engine>'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:391:in `instance_exec'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:391:in `block in make_lambda'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:285:in `block in halting'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:447:in `block in around'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:455:in `call'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:101:in `__run_callbacks__'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:750:in `_run_unsubscribe_callbacks'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:90:in `run_callbacks'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/channel/base.rb:175:in `unsubscribe_from_channel'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/connection/subscriptions.rb:44:in `remove_subscription'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/connection/subscriptions.rb:57:in `block in unsubscribe_from_all'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/connection/subscriptions.rb:57:in `each'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/connection/subscriptions.rb:57:in `unsubscribe_from_all'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/connection/base.rb:182:in `handle_close'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/server/worker.rb:58:in `block in invoke'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/server/worker.rb:39:in `block in work'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:126:in `call'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:506:in `block (2 levels) in compile'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:455:in `call'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:448:in `block (2 levels) in around'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:286:in `block (2 levels) in halting'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/server/worker/active_record_connection_management.rb:14:in `block in with_database_connections'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/connection/tagged_logger_proxy.rb:24:in `tag'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/server/worker/active_record_connection_management.rb:14:in `with_database_connections'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:382:in `block in make_lambda'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:285:in `block in halting'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:447:in `block in around'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:455:in `call'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:448:in `block (2 levels) in around'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:286:in `block (2 levels) in halting'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/engine.rb:60:in `block (4 levels) in <class:Engine>'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/execution_wrapper.rb:76:in `wrap'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/engine.rb:55:in `block (3 levels) in <class:Engine>'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:391:in `instance_exec'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:391:in `block in make_lambda'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:285:in `block in halting'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:447:in `block in around'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:455:in `call'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:101:in `__run_callbacks__'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:750:in `_run_work_callbacks'
/opt/rh/cfme-gemset/gems/activesupport-5.0.0.1/lib/active_support/callbacks.rb:90:in `run_callbacks'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/server/worker.rb:38:in `work'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/server/worker.rb:56:in `invoke'
/opt/rh/cfme-gemset/gems/actioncable-5.0.0.1/lib/action_cable/server/worker.rb:51:in `block in async_invoke'
/opt/rh/cfme-gemset/gems/concurrent-ruby-1.0.2/lib/concurrent/executor/ruby_thread_pool_executor.rb:348:in `run_task'
/opt/rh/cfme-gemset/gems/concurrent-ruby-1.0.2/lib/concurrent/executor/ruby_thread_pool_executor.rb:337:in `block (3 levels) in create_worker'
/opt/rh/cfme-gemset/gems/concurrent-ruby-1.0.2/lib/concurrent/executor/ruby_thread_pool_executor.rb:320:in `loop'
/opt/rh/cfme-gemset/gems/concurrent-ruby-1.0.2/lib/concurrent/executor/ruby_thread_pool_executor.rb:320:in `block (2 levels) in create_worker'
/opt/rh/cfme-gemset/gems/concurrent-ruby-1.0.2/lib/concurrent/executor/ruby_thread_pool_executor.rb:319:in `catch'
/opt/rh/cfme-gemset/gems/concurrent-ruby-1.0.2/lib/concurrent/executor/ruby_thread_pool_executor.rb:319:in `block in create_worker'
[----] I, [2016-10-03T05:42:37.714563 #11819:e68994]  INFO -- : Started GET "/ems_infra/compare_miq" for 127.0.0.1 at 2016-10-03 05:42:37 -0400
[----] I, [2016-10-03T05:42:37.717860 #11819:e68994]  INFO -- : Processing by EmsInfraController#compare_miq as HTML
[----] I, [2016-10-03T05:42:37.854478 #11819:e68994]  INFO -- :   Rendered shared/_compare_header_expanded.html.haml (15.9ms)
[----] I, [2016-10-03T05:42:37.870280 #11819:e68994]  INFO -- :   Rendered shared/_compare_header_expanded.html.haml (15.0ms)
[----] F, [2016-10-03T05:42:37.876103 #11819:e68994] FATAL -- : Error caught: [ActionView::MissingTemplate] Missing template ems_infra/show, application/show with {:locale=>[:en], :formats=>[:html], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby, :coffee, :haml, :jbuilder, :rjs]}. Searched in:
  * "/var/www/miq/vmdb/app/views"
  * "/opt/rh/rh-ruby23/root/usr/share/gems/gems/redhat_access_cfme-1.1.0/app/views"

/opt/rh/cfme-gemset/gems/actionview-5.0.0.1/lib/action_view/path_set.rb:46:in `find'

[Fryguy]

Removing pinned label so it doesn't get lost.

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[miq-bot]

This issue has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this issue if this issue is still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.