search

ManageIQ / manageiq-ui-classic

Classic UI of ManageIQ
Apache License 2.0
49 stars 359 forks source link

Break up methods that manipulate with the session data into smaller pieces #4963

Open skateman opened 5 years ago

skateman commented 5 years ago

These methods are too large and not very readable, also not symmetric enough. Also for specific controller actions we don't want to run some pieces of these methods, such as remembering tabs for printing. For now these kind of exceptions are sorted out with a lot of if/else/case logic but by doing the split we could leverage the skip_before_action method that can be set per controller action instead of a globally used logic.

/cc @himdel @martinpovolny

@miq-bot add_label refactoring @miq-bot assign @skateman

miq-bot commented 5 years ago

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

mfeifer commented 4 years ago

@skateman is this done? or should it be pinned?

skateman commented 4 years ago

@miq-bot add_label pinned