Replace the trees with the new (react) tree component

ManageIQ / manageiq-ui-classic

Classic UI of ManageIQ

Apache License 2.0

50 stars 357 forks source link

Replace the trees with the new (react) tree component #5178

Open martinpovolny opened 5 years ago

martinpovolny commented 5 years ago

Create a temporary wrapper around tree manipulation JS code to allow 2 (Angular, React+Redux) implementations at the same time
Implement the tree manipulation functions (miq_explorer.js, miq_tree.js) for the React component
Replace the old treeview component with the new one
Drop the Angular-based tree view manipulation code and the wrapper
Move the tree state from the session to Redux
Create and consume API-like endpoints for tree building (tree_controller.rb)

martinpovolny commented 5 years ago

ping @brumik

skateman commented 5 years ago

We just had a meeting with @brumik, gave him the following tasks:

[ ] Go through the tree manipulation functions in miq_tree.js and miq_explorer.js
[ ] Understand what the tree manipulation functions do, write down the explanations here
[ ] Design reducers that could possibly replace these functions
[ ] Create a demo tree with redux and implement these reducers in it

In the meantime I will be doing these things:

[ ] Beat the TreeBuilder classes until they look prettier
[ ] Detach the TreeState more from the trees and make it pluggable
[ ] Pass the TreeState from request params in TreeController
[ ] Convert some flat trees to listnavs to make the work look less
[ ] Add all remaining left-side rendered trees into the TreeController

The goal is to have JSON endpoints for all left side explorer trees and use the React component to render the tree while storing its state in Redux instead of storing it on the server-side session.

miq-bot commented 4 years ago

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

skateman commented 4 years ago

@miq-bot rm_label stale

skateman commented 4 years ago

So after https://github.com/ManageIQ/manageiq-ui-classic/pull/6413 gets in, we will have these callsites of building trees:

using the new HierarchicalTreeView react component
using the miqTreeView angular component in left-side explorers
using the miqTreeView angular component in generic objects :hippopotamus: :skull:
using the miqTreeView angular component for embedded methods in automate
using the miqTreeView angular component for dialog editor automate entrypoint selection

himdel commented 4 years ago

Some current state (from https://github.com/ManageIQ/manageiq-ui-classic/pull/6413#discussion_r414695047)..

Left side explorer trees:

explorer trees (angular): listnav/_explorer layout
generic object (angular): listnav/_generic_object_definition_show_list_with_treeview layout - TODO merge with listnav/_explorer

relevant: some will be removed, some moved to independent screens for https://github.com/ManageIQ/manageiq-ui-classic/issues/6819:

Right side trees:

shared/_tree converted to react in #6413
extra react miq_policy/_alert_profile_assign - TODO should become part of #6413 and use shared/_tree

miq-bot commented 1 year ago

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.