ManageIQ / manageiq-ui-classic

Classic UI of ManageIQ
Apache License 2.0
50 stars 357 forks source link

Missing react component: expression editor #6835

Open himdel opened 4 years ago

himdel commented 4 years ago

Expression editor, rendered from the layouts/exp_editor partial (app/views/layouts/_exp_editor.html.haml).

Found in:

caller menu issue
app/controllers/application_controller/filter.rb internal - exp_button / exp_token_pressed rerender -
app/views/miq_ae_class/_method_form.html.haml:69
app/views/layouts/_filter_expression.html.haml:16
app/views/layouts/_adv_search_body.html.haml:17 advanced search #6948
app/views/report/_form_filter.html.haml:18,33
app/views/miq_policy/_alert_details.html.haml:156
app/views/miq_policy/_form_scope.html.haml:4
app/views/miq_policy/_form_expression.html.haml:10
app/views/miq_policy/_policy_details.html.haml:63

the views above not only include exp_editor but often also render a part of the view.

Configuration >> Access Control; Groups / Configuration / Add a new group #6905 Automation > Automate > Customization >> Buttons; Add/Edit Button/ButtonGroup #6910 Control > Explorer >> Policies; Add/Edit #6913 Contro > Explorer >> Conditions; Add/Edit #6914

Per column operators: MiqExpression.get_col_operators, MiqExpression.model_details selections in UI ExpAtomHelper,

himdel commented 4 years ago

wip in https://github.com/ManageIQ/react-ui-components/pull/89 / https://github.com/ManageIQ/react-ui-components/pull/149

himdel commented 4 years ago

API changes in https://github.com/ManageIQ/manageiq-api/pull/712

(we won't be doing autocomplete for now, but it seems we can use the proposed API to populate all the field choices)

skateman commented 3 years ago

The new component should also support accessibility, added it to the list of tasks there.

kavyanekkalapu commented 3 years ago

@GilbertCherrie and i had a discussion with @Fryguy on this issue, some points from discussion:

@Fryguy If i miss adding anything, feel free to add more here.

kavyanekkalapu commented 3 years ago

Opened api issue for this https://github.com/ManageIQ/manageiq-api/issues/1044.

miq-bot commented 1 year ago

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.