breadcrumb and highlighted links for physical storages not working as expected

ManageIQ / manageiq-ui-classic

Classic UI of ManageIQ

Apache License 2.0

50 stars 358 forks source link

breadcrumb and highlighted links for physical storages not working as expected #7471

Open llivne opened 3 years ago

llivne commented 3 years ago

1) physical storages page can be access from 2 places:

Storage > Block storage > Storages
Compute > Physical Infrastructure > Storages

the breadcrumb for it is always Compute > Physical Infrastructure > Storages even if we go to the page from block storage. Also, the breadcrumbs links are always to compute -> physical Infrastructure -> storages

2) Both links 'Storage > Block storage > Storages' and 'Compute > Physical Infrastructure > Storages' highlighted if we are in the storage page

skateman commented 3 years ago

IMO this should be just under one menu item, I'm vouching for Storage as it's more intuitive compared to Compute that only makes sense if the 2nd level is expanded where the user can see Physical Infra.

wdyt @Fryguy @gtanzillo
@miq-bot add_label question

skateman commented 3 years ago

Maybe we should name it Physical Storage in the menu though: Screenshot from 2020-11-02 13-45-11

Fryguy commented 3 years ago

I'm not sure... Would like @agrare to weigh in here.

agrare commented 3 years ago

@skateman what do we do for other types which can live under multiple manager types? CloudVolumes comes to mind. Do we show them under the storage section even if they belong to a cloud_manager?

skateman commented 3 years ago

Yes