Replace angular code

[himdel]

We do have a lot of angular.js 1.x code that should eventually be rewritten to react or DDF, as per version-support-status, it ends LTS in Dec 2021.

We don't use angular router, or ng-app, so any angular code needs miq_bootstrap to render (which uses angular.bootstrap to run angular).

This happens from:

• [ ] error modal - a self contained component that pops up a modal on unexpected 4 or 5 HTTP responses, shoud be trivial to rewrite

Views - forms (find issues)

• miq_ae_class/:

  • [ ] _angular_method_form.html.haml -(Automation/Automate/Explorer/Datastore -> Select a Domain -> Select a Namespace -> Select a Class -> Add a New Method) - (Expression Editor by @amalvijayan03 - https://github.com/ManageIQ/manageiq-ui-classic/pull/8944)
  • [ ] _embedded_methods.html.haml - (Same Form as Above but When Adding a New Method, Set Type to Inline)

• ops/:

  • [ ] _settings_replication_tab.html.haml - (Settings -> Application Settings -> Settings -> Select Region -> Replication)

Views - dialog user/editor:

• miq_ae_customization/:
  • [ ] editor.html.haml - dialog editor (Automation/Automate/Customization/Service Dialogs -> Add a new Dialog)
• shared/dialogs/:
  • [ ] _reconfigure_dialog.html.haml - dialog user in reconfigure mode https://github.com/ManageIQ/manageiq-ui-classic/pull/8951
  • [ ] _dialog_user.html.haml - dialog user proper https://github.com/ManageIQ/manageiq-ui-classic/pull/8911

Views - unsorted:

• layouts/listnav/:
  • [ ] _explorer.html.haml
    • [ ] - every navigation/explorer tree in the ui except the one in generic_objects (listed in https://github.com/ManageIQ/manageiq-ui-classic/issues/6819)
  • [ ] _generic_object_definition_show_list_with_treeview.html.haml - generic objects show_list navigation tree (Automation/Automate/Generic Objects)

We also have multiple angular plugins - see https://github.com/ManageIQ/manageiq-ui-classic/pull/6452#issuecomment-686788083 And components in ui-components - issue already exists: https://github.com/ManageIQ/manageiq-ui-classic/issues/6716

Previous Releases:

• https://github.com/ManageIQ/manageiq-ui-classic/issues/8297
• https://github.com/ManageIQ/manageiq-ui-classic/issues/8299
• https://github.com/ManageIQ/manageiq-ui-classic/issues/8417
• https://github.com/ManageIQ/manageiq-ui-classic/issues/9031
• https://github.com/ManageIQ/manageiq-ui-classic/issues/9032

[Fryguy]

Updated to checkboxes 😄

[Fryguy]

@himdel Can you reorganize the list so that provider dashboards are grouped together? I'm wondering if we focused on a provider dashboard react component if that would knock off a huge chunk of the list.

[himdel]

Resorted and split into forms, dashboards, topologies, a few trivial uses ..and the rest :).

[himdel]

Another nontrivial part that stands out is generic object + generic object definition - those screens are fully angular (and have additional issues) - might be another candidate for dropping?

[himdel]

Hopefully we have 0 class-based directives, as those are impossible to distinguish from css classes.

And as for attribute directives, I'm seeing..

• [ ] pf-form-group with pf-label - can be replaced by a class and a label element
• [ ] pf-select - can be replaced by our miq-select fork (from ui-components)

[Fryguy]

Another nontrivial part that stands out is generic object + generic object definition - those screens are fully angular (and have additional issues) - might be another candidate for dropping?

I don't think we can drop that...looks like we'll have to covert to react.

[chessbyte]

Amazing that this list is down to ~20 items! Nice work everyone!

[GilbertCherrie]

Updated the issue to move all completed points from this master issue to the new Petrosian and Quinteros issues.

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.