Open mend-bolt-for-github[bot] opened 2 years ago
We can't fix this for now as we are using latest v3 angular-pattenfly. We are not ready to upgrade it to 4.
:heavy_check_mark: This issue was automatically closed by WhiteSource because the vulnerable library in the specific branch(es) was either marked as ignored or it is no longer part of the WhiteSource inventory.
:information_source: This issue was automatically re-opened by WhiteSource because the vulnerable library in the specific branch(es) has been detected in the WhiteSource inventory.
This issue has been automatically marked as stale because it has not been updated for at least 3 months.
If you can still reproduce this issue on the current release or on master
, please reply with all of the information you have about it in order to keep the issue open.
Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.
Adding some more details for as to why we're still on angular-patternfly v3.
There are several breaking changes between v3 and v4. Most interesting to our case is in https://github.com/ManageIQ/manageiq-ui-classic/blob/b24778a0db8be3fd4834a823995c280f5942c0a5/app/views/static/ops/log_collection/log_collection.html.haml#L17-L23
Were you can see we still use pf-select
with ng-options
.
We also use pf-list-view
however since we don't seem to use actionButton class this file might not cause issues during upgrade.
https://github.com/ManageIQ/manageiq-ui-classic/blob/b24778a0db8be3fd4834a823995c280f5942c0a5/app/views/shared/views/_alerts_list.html.haml#L3-L8
In regards to the third breaking change, pfInlineNotification
, we don't seem to use that in our repo.
Both of these pages are on the Chopping Block https://github.com/ManageIQ/manageiq/issues/21377. As such once these files are removed we should be able to upgrade to v4 angular-patternfly
with no problem. Additionally it looks like there are no major changes between v4 and v5 so once we should push through to latest.
Marking as blocked.
This issue has been automatically marked as stale because it has not been updated for at least 3 months.
If you can still reproduce this issue on the current release or on master
, please reply with all of the information you have about it in order to keep the issue open.
CVE-2019-10768 - High Severity Vulnerability
Vulnerable Libraries - angular-1.5.11.tgz, angular-1.6.10.tgz
angular-1.5.11.tgz
HTML enhanced for web apps
Library home page: https://registry.npmjs.org/angular/-/angular-1.5.11.tgz
Path to dependency file: /package.json
Path to vulnerable library: /home/wss-scanner/.yarn/berry/cache/angular-npm-1.5.11-136e8acd47-10.zip
Dependency Hierarchy: - angular-patternfly-3.26.0.tgz (Root Library) - :x: **angular-1.5.11.tgz** (Vulnerable Library)
angular-1.6.10.tgz
HTML enhanced for web apps
Library home page: https://registry.npmjs.org/angular/-/angular-1.6.10.tgz
Path to dependency file: /package.json
Path to vulnerable library: /home/wss-scanner/.yarn/berry/cache/angular-npm-1.6.10-36c4afca0d-10.zip
Dependency Hierarchy: - :x: **angular-1.6.10.tgz** (Vulnerable Library)
Found in HEAD commit: d87706978173ac6516da5e83374518c21263b77b
Found in base branch: master
Vulnerability Details
In AngularJS before 1.7.9 the function `merge()` could be tricked into adding or modifying properties of `Object.prototype` using a `__proto__` payload. Mend Note: After conducting further research, Mend has determined that versions 1.4.0-beta.6 before 1.7.9 of angular are vulnerable to CVE-2019-10768. Converted from WS-2019-0367, on 2021-07-21.
Publish Date: 2019-11-19
URL: CVE-2019-10768
CVSS 3 Score Details (7.5)
Base Score Metrics: - Exploitability Metrics: - Attack Vector: Network - Attack Complexity: Low - Privileges Required: None - User Interaction: None - Scope: Unchanged - Impact Metrics: - Confidentiality Impact: None - Integrity Impact: High - Availability Impact: None
For more information on CVSS3 Scores, click here.Suggested Fix
Type: Upgrade version
Release Date: 2019-11-19
Fix Resolution (angular): 1.7.9
Direct dependency fix Resolution (angular-patternfly): 5.0.0
Step up your Open Source Security Game with Mend here