search

ManageIQ / manageiq-ui-classic

Classic UI of ManageIQ
Apache License 2.0
49 stars 357 forks source link

Service Summary display is duplicated #9218

Closed uejo closed 3 weeks ago

uejo commented 1 month ago

  1. Describe the issue you are having and what you expected to happen. The Service Summary in the Classic UI displays the Summary twice, even with glitches. It should only be displayed once. Also it should not have 2 scroll bars.

  2. Describe the steps to reproduce, including any log snippets and stack traces that will help diagnose. Create a Service and scroll down.

  3. Describe your environment:

    • Version: radjabov-pre.20240404134108_e4479a1
    • Environment
      • For ManageIQ: VMware appliance

image

GilbertCherrie commented 1 month ago

I can't reproduce this. What branch are you currently running on and what type of service is this, as in can you provide the steps on what you provisioned before you viewed this page.

uejo commented 1 month ago

Hi I used the radjabov build with e4479a1 commit hash, and also i have a build with commit 150c6b9 with the same issue. So i guess it downloaded the current ui which existed at this time. Im creating a service in the service catalog using the "vmware" catalog item type. Then i deploy a vm with this service catalog. Nothing really special. I justed tested it on the current docker image "latest". And i dont see this behavior. So it might be a radjabov issue? Since everything else works fine after the build, i dont know if i messed something up during the build.

GilbertCherrie commented 1 month ago

@uejo I can't seem to replicate this issue. If this was a one off error and it is currently working can we close out this issue?

uejo commented 1 month ago

Hey @GilbertCherrie i tested some different browser and also the private mode. And thats where i found some differences. Using edge/firefox/chrome i have those doubled service display. Using the private mode for edge i didnt have this issue. So i inspected the page and found this at the bottom, which is duplicating the service view: image

The interesting part is, it is not double rendered in private mode in edge or chrome but using default mode it is doubled, at least in my current radjabov build. I then started the latest manageiq container from docker hub, created a generic service and inspected the HTML code there as well. I found this double div class there as well, with the difference its somehow not rendered even so its there. I think this div class ="row" should not be there twice right? Because if i remove it in my case, the site would look like intended.

GilbertCherrie commented 1 month ago

Thanks for that find. This issue should be fixed by this pr: https://github.com/ManageIQ/manageiq-ui-classic/pull/9228 since it prevents this duplicate div being rendered.