ManageIQ / manageiq-ui-classic

Classic UI of ManageIQ
Apache License 2.0
50 stars 358 forks source link

Remove item.html.haml #97

Open martinpovolny opened 7 years ago

martinpovolny commented 7 years ago

Some entities don't use textual summary, but instead call this strange partial:

app/views/layouts/_item.html.haml

This is a mess and an exception and we need to get rid of it.

Task: remove this partial, use textual summary where possible instead. Create a special partial per entity, if/where it's not possible to use textal summar and place is under app/views/<entity/.

miq-bot commented 6 years ago

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

JPrause commented 5 years ago

@martinpovolny is this still a valid issue? If yes, lease remove the stale label. If not can you close. If there's no update by next week, I'll be closing this issue.

martinpovolny commented 5 years ago

Still valid:

lucifer - [~/Projects/manageiq-ui-classic] (master)$ grep -r /item app/views/ | grep render
app/views/cloud_tenant/show.html.haml:      = render :partial => "layouts/item"
app/views/service/generic_object.html.haml:    = render :partial => 'layouts/item'
app/views/cloud_object_store_object/show.html.haml:    = render :partial => "layouts/item"
app/views/host/show.html.haml:      = render :partial => "layouts/item"
app/views/cloud_volume/show.html.haml:    = render :partial => "layouts/item"
app/views/host_aggregate/show.html.haml:      = render :partial => "layouts/item"
app/views/flavor/show.html.haml:    = render :partial => "layouts/item"
app/views/miq_template/show.html.haml:      = render :partial => "layouts/item"
app/views/orchestration_stack/show.html.haml:    = render(:partial => "layouts/item")
app/views/configuration_job/show.html.haml:    = render(:partial => "layouts/item")
app/views/availability_zone/show.html.haml:      = render :partial => "layouts/item"
app/views/ems_cluster/show.html.haml:      = render :partial => "layouts/item"
app/views/storage/show.html.haml:      = render :partial => "layouts/item"
app/views/shared/views/ems_common/_show.html.haml:    = render(:partial => "layouts/item")
app/views/container_image/show.html.haml:    = render :partial => "layouts/item"
miq-bot commented 5 years ago

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

martinpovolny commented 5 years ago

Still valid.

martinpovolny commented 4 years ago

*$ grep -r 'render.item' app/views/**

app/views/ops/_rbac_tagging.html.haml:= render :partial => "layouts/tag_edit_items"
app/views/cloud_tenant/show.html.haml:      = render :partial => "layouts/item"
app/views/service/generic_object.html.haml:    = render :partial => 'layouts/item'
app/views/cloud_object_store_object/show.html.haml:    = render :partial => "layouts/item"
app/views/host/show.html.haml:      = render :partial => "layouts/item"
app/views/cloud_volume/show.html.haml:    = render :partial => "layouts/item"
app/views/host_aggregate/show.html.haml:      = render :partial => "layouts/item"
app/views/flavor/show.html.haml:    = render :partial => "layouts/item"
app/views/layouts/_x_tagging.html.haml:= render :partial => "layouts/tag_edit_items"
app/views/layouts/_protect.html.haml:    = render :partial => 'layouts/info_msg', :locals => {:message => _("* Policy Profile is only applied to some of the items below.")}
app/views/layouts/_tagging.html.haml:= render :partial => "layouts/tag_edit_items"
app/views/miq_template/show.html.haml:      = render :partial => "layouts/item"
app/views/orchestration_stack/show.html.haml:    = render(:partial => "layouts/item")
app/views/configuration_job/show.html.haml:    = render(:partial => "layouts/item")
app/views/availability_zone/show.html.haml:      = render :partial => "layouts/item"
app/views/ems_cluster/show.html.haml:      = render :partial => "layouts/item"
app/views/storage/show.html.haml:      = render :partial => "layouts/item"
app/views/shared/views/ems_common/_show.html.haml:    = render(:partial => "layouts/item")
app/views/container_image/show.html.haml:    = render :partial => "layouts/item"

Still called from any places. Somone needs to go case by case, file by file figure if each branch is live and remove this.

miq-bot commented 4 years ago

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.

chessbyte commented 3 years ago
$ grep -r /item app/views/ | grep render
app/views//container_image/show.html.haml:    = render :partial => "layouts/item"
app/views//host/show.html.haml:      = render :partial => "layouts/item"
app/views//ems_cluster/show.html.haml:      = render :partial => "layouts/item"
app/views//availability_zone/show.html.haml:      = render :partial => "layouts/item"
app/views//configuration_job/show.html.haml:    = render(:partial => "layouts/item")
app/views//cloud_volume/show.html.haml:    = render :partial => "layouts/item"
app/views//cloud_object_store_object/show.html.haml:    = render :partial => "layouts/item"
app/views//shared/views/ems_common/_show.html.haml:    = render(:partial => "layouts/item")
app/views//host_aggregate/show.html.haml:      = render :partial => "layouts/item"
app/views//storage/show.html.haml:      = render :partial => "layouts/item"
app/views//miq_template/show.html.haml:      = render :partial => "layouts/item"
app/views//cloud_tenant/show.html.haml:      = render :partial => "layouts/item"
app/views//storage_resource/show.html.haml:    = render :partial => "layouts/item"
app/views//service/generic_object.html.haml:    = render :partial => 'layouts/item'
app/views//flavor/show.html.haml:    = render :partial => "layouts/item"
app/views//host_initiator/show.html.haml:    = render :partial => "layouts/item"
app/views//orchestration_stack/show.html.haml:    = render(:partial => "layouts/item")
miq-bot commented 1 year ago

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.