improving requirements for updates in the development guide

ManageIQ / manageiq-vagrant-dev

Vagrantfile and scripts so you can start a developer environment

Apache License 2.0

5 stars 16 forks source link

improving requirements for updates in the development guide #3

Closed chargio closed 7 years ago

chargio commented 7 years ago

This PR changes some details to reflect updates in the development guide:

Makes memory for the VM 6 GB, instead of 4
Install yarn
Improves the method used to reboot the VM when needed
Updates hostname to avoid "-" and "_", just in case.

Fryguy commented 7 years ago

Updates ruby to 2.4.1

ManageIQ appliances nor docker containers do this, so why is this here? The project doesn't even work on 2.4 yet.

Fryguy commented 7 years ago

@simaishi Please review

chargio commented 7 years ago

@Fryguy What is the correct version of ruby? I've seen the PR merged that allows 2.4.1 to be used.

https://github.com/ManageIQ/manageiq/pull/13104

Should it be 2.3.3 or 2.3.1?

Fryguy commented 7 years ago

@sergio-ocon yeah, those changes are 2.2, 2.3, and 2.4 compatible changes to move us towards 2.4 support but we are not there yet. @jrafanie has a checklist going: https://github.com/ManageIQ/manageiq/issues/14446 . That being said, many of us just use 2.4 locally anyway, and I haven't seen anything fail yet, but then again, I don't run the entire app locally either.

We use Ruby 2.3.1 in the appliances, so I would go with that for maximum compatibility. https://github.com/ManageIQ/manageiq-appliance-build/blob/master/kickstarts/partials/post/ruby_install.ks.erb#L10

chargio commented 7 years ago

@Fryguy I believe that this now is ok. I will merge it when you approve it.