Refactoring view related JavaScripts (onload, styling, etc)

ManageIQ / manageiq

ManageIQ Open-Source Management Platform

https://manageiq.org

Apache License 2.0

1.35k stars 898 forks source link

Refactoring view related JavaScripts (onload, styling, etc) #12017

Closed skateman closed 7 years ago

skateman commented 8 years ago

Currently we're calling too much JS on too many places. Also we're exposing a lot of JS functions on pages where it is completely unnecessary (login, consoles, etc). So my idea is to:

Divide our non-app views into a few categories based on what kind of JS they require
Create new JS metafiles for each category where only the necessary JS gets loaded
Add these new metafiles to the config/initializers/assets.rb
Replace old JS inclusions with these metafiles in javascript_include_tag calls
Clean up all unnecessary JS files

The term metafile means a JS file with //= require calls only, that is parsed by the asset pipeline.

https://www.pivotaltracker.com/story/show/132650949

skateman commented 8 years ago

cc @martinpovolny @himdel @dclarizio

martinpovolny commented 8 years ago

@skateman: I wonder about priority of this refactoring compared to other refactoring tasks. See search label:"tech_debt/refactoring" in UI project in pivotal.

I mean those are issues that grow with time as people cut-n-paste around and will grow until we address them.

Also see: https://www.pivotaltracker.com/n/projects/1619601 backlog, there I created tasks related to UI splitting.

Overall I think that this is a nice refactoring/cleanup part but there are others with higher priority. (See e.g. issues I created yesterday).

skateman commented 8 years ago

@martinpovolny sure, it's definitely a low-priority task, just wanted to document this idea before I forget it (again).

martinpovolny commented 8 years ago

Will you add it to pivotal?

skateman commented 8 years ago

https://www.pivotaltracker.com/story/show/132650949

miq-bot commented 7 years ago

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

skateman commented 7 years ago

I think we can close this because of the webpacker stuff...