Use Generic.*Mixins in controllers

jzigmund commented 7 years ago

Starting issue for this issue is https://github.com/ManageIQ/manageiq/issues/11979 https://www.pivotaltracker.com/epic/show/3144799

GenericSessionMixin Affected controller methods:

def get_session_data
def set_session_data

Goal: Code uses session handling methods (getter/setter of session object/controller's vars) from the mixin.

Controllers with the methods:

[ ] app/controllers/mixins/vm_show_mixin.rb
[ ] app/controllers/vm_controller.rb
[ ] app/controllers/mixins/containers_common_mixin.rb
[ ] app/controllers/dashboard_controller.rb
[ ] app/controllers/pxe_controller.rb
[ ] app/controllers/miq_ae_tools_controller.rb
[ ] app/controllers/miq_template_controller.rb
[ ] app/controllers/ems_infra_dashboard_controller.rb
[ ] app/controllers/infra_networking_controller.rb
[ ] app/controllers/storage_manager_controller.rb
[ ] app/controllers/host_aggregate_controller.rb
[ ] app/controllers/availability_zone_controller.rb
[ ] app/controllers/ems_cluster_controller.rb
[ ] app/controllers/configuration_controller.rb
[ ] app/controllers/topology_controller.rb
[ ] app/controllers/ems_common.rb
[ ] app/controllers/miq_policy_controller.rb
[ ] app/controllers/miq_ae_customization_controller.rb
[ ] app/controllers/container_dashboard_controller.rb
[ ] app/controllers/service_controller.rb
[ ] app/controllers/alert_controller.rb
[ ] app/controllers/host_controller.rb
[ ] app/controllers/cloud_tenant_controller.rb
[ ] app/controllers/cloud_object_store_object_controller.rb
[ ] app/controllers/orchestration_stack_controller.rb
[ ] app/controllers/configuration_job_controller.rb
[ ] app/controllers/ops_controller.rb
[ ] app/controllers/cloud_volume_controller.rb
[ ] app/controllers/miq_task_controller.rb
[ ] app/controllers/miq_capacity_controller.rb
[ ] app/controllers/provider_foreman_controller.rb
[ ] app/controllers/miq_request_controller.rb
[ ] app/controllers/chargeback_controller.rb
[ ] app/controllers/cloud_volume_backup_controller.rb
[ ] app/controllers/support_controller.rb
[ ] app/controllers/report_controller.rb
[ ] app/controllers/miq_ae_class_controller.rb
[ ] app/controllers/catalog_controller.rb

GenericShowMixin Affected controller method:

def show

Goal: Code uses show method to display data about a resource or a nested resource from the mixin.

Controllers with the method:

[ ] app/controllers/mixins/middleware_common_mixin.rb
[ ] app/controllers/mixins/containers_common_mixin.rb
[ ] app/controllers/dashboard_controller.rb
[ ] app/controllers/miq_ae_tools_controller.rb
[ ] app/controllers/ems_infra_dashboard_controller.rb
[ ] app/controllers/middleware_domain_controller.rb
[ ] app/controllers/ontap_file_share_controller.rb
[ ] app/controllers/middleware_server_controller.rb
[ ] app/controllers/ontap_storage_system_controller.rb
[ ] app/controllers/storage_manager_controller.rb
[ ] app/controllers/cim_storage_extent_controller.rb
[ ] app/controllers/host_aggregate_controller.rb
[ ] app/controllers/availability_zone_controller.rb
[ ] app/controllers/ems_cluster_controller.rb
[ ] app/controllers/resource_pool_controller.rb
[ ] app/controllers/topology_controller.rb
[ ] app/controllers/configuration_controller.rb
[ ] app/controllers/container_controller.rb
[ ] app/controllers/container_dashboard_controller.rb
[ ] app/controllers/ems_common.rb
[ ] app/controllers/service_controller.rb
[ ] app/controllers/middleware_server_group_controller.rb
[ ] app/controllers/ontap_logical_disk_controller.rb
[ ] app/controllers/host_controller.rb
[ ] app/controllers/cloud_object_store_object_controller.rb
[ ] app/controllers/orchestration_stack_controller.rb
[ ] app/controllers/configuration_job_controller.rb
[ ] app/controllers/consumption_controller.rb
[ ] app/controllers/cloud_volume_controller.rb
[ ] app/controllers/miq_request_controller.rb
[ ] app/controllers/snia_local_file_system_controller.rb
[ ] app/controllers/support_controller.rb
[ ] app/controllers/ontap_storage_volume_controller.rb
[ ] app/controllers/catalog_controller.rb

GenericButtonMixin Affected controller method:

def button

Controllers with the method:

[ ] app/controllers/mixins/containers_common_mixin.rb
[ ] app/controllers/mixins/middleware_operations_mixin.rb
[ ] app/controllers/storage_controller.rb (in progress - @hayesr)
[ ] app/controllers/miq_ae_tools_controller.rb
[ ] app/controllers/ontap_file_share_controller.rb
[ ] app/controllers/middleware_server_controller.rb
[ ] app/controllers/cloud_subnet_controller.rb
[ ] app/controllers/storage_manager_controller.rb
[ ] app/controllers/infra_networking_controller.rb
[ ] app/controllers/cim_storage_extent_controller.rb
[ ] app/controllers/ontap_storage_system_controller.rb
[ ] app/controllers/host_aggregate_controller.rb
[ ] app/controllers/ems_cluster_controller.rb
[ ] app/controllers/availability_zone_controller.rb
[ ] app/controllers/cloud_network_controller.rb
[ ] app/controllers/resource_pool_controller.rb (in progress - @jzigmund)
[ ] app/controllers/network_router_controller.rb
[ ] app/controllers/container_controller.rb
[ ] app/controllers/miq_policy_controller.rb
[ ] app/controllers/ems_common.rb
[ ] app/controllers/configuration_controller.rb
[ ] app/controllers/vm_common.rb
[ ] app/controllers/service_controller.rb
[ ] app/controllers/ontap_logical_disk_controller.rb
[ ] app/controllers/cloud_object_store_object_controller.rb
[ ] app/controllers/orchestration_stack_controller.rb
[ ] app/controllers/cloud_tenant_controller.rb
[ ] app/controllers/host_controller.rb
[ ] app/controllers/configuration_job_controller.rb
[ ] app/controllers/miq_task_controller.rb
[ ] app/controllers/cloud_volume_controller.rb
[ ] app/controllers/miq_request_controller.rb
[ ] app/controllers/snia_local_file_system_controller.rb
[ ] app/controllers/cloud_object_store_container_controller.rb
[ ] app/controllers/ontap_storage_volume_controller.rb
[ ] app/controllers/auth_key_pair_cloud_controller.rb

GenericListMixin Affected controller methods:

def index
def show_list

Controllers with the methods:

[ ] app/controllers/vm_controller.rb
[ ] app/controllers/storage_manager_controller.rb
[ ] app/controllers/ems_container_controller.rb
[ ] app/controllers/container_controller.rb
[ ] app/controllers/container_project_controller.rb
[ ] app/controllers/host_controller.rb
[ ] app/controllers/orchestration_stack_controller.rb
[ ] app/controllers/container_group_controller.rb
[ ] app/controllers/container_image_controller.rb
[ ] app/controllers/auth_key_pair_cloud_controller.rb

miq-bot commented 7 years ago

@jzigmund @hayesr @jzigmund is an invalid user, ignoring...

hayesr commented 7 years ago

@miq-bot assign @hayesr

PanSpagetka commented 7 years ago

https://github.com/ManageIQ/manageiq-ui-classic/pull/1390 https://github.com/ManageIQ/manageiq-ui-classic/pull/1387 https://github.com/ManageIQ/manageiq-ui-classic/pull/1356

PanSpagetka commented 7 years ago

Status for Show:

TO DO: app/controllers/host_aggregate_controller.rb app/controllers/storage_controller.rb

Hard to convert: app/controllers/dashboard_controller.rb app/controllers/miq_request_controller.rb

Other occurrences of show just redirecting or setting some variables.

ManageIQ / manageiq

Use Generic.*Mixins in controllers #13057