search

ManageIQ / manageiq

ManageIQ Open-Source Management Platform
https://manageiq.org
Apache License 2.0
1.35k stars 898 forks source link

InventoryCollection Builder #17396

Closed slemrmartin closed 5 years ago

slemrmartin commented 6 years ago

New Interface for definition/creating InventoryCollection from persister (ManagerRefresh::Inventory::Persister and its provider specific subclasses) Accessible via _addcollection() method

Intended to replace:

_add_inventorycollection() method _hasinventory() method Classes ManagerRefresh::InventoryCollection::Builder and descendants can replace:

ManagerRefresh::InventoryCollectionDefault and subclasses (using add_inventory_collection interface) ManagerRefresh::Inventory::Core module (and classes including it - using _hasinventory() interface) IC model class is derived from persister class and IC association value IC inventory_object_attributes are derived from setters of model_class IC parent added automatically if missing (all can be disabled by settings)

Documentation: https://github.com/ManageIQ/guides/blob/master/providers/persister/inventory_collections.md https://github.com/ManageIQ/guides/pull/316

Pull requests:

Optimizations:

Final cleanup (depends on all previous PRs)

slemrmartin commented 6 years ago

@miq-bot add_label providers/inventory @miq-bot add_label refactoring

JPrause commented 5 years ago

@slemrmartin is this still an open issue? If not, can you close it.

slemrmartin commented 5 years ago

it's complete, @JPrause, closing it