search

ManageIQ / manageiq

ManageIQ Open-Source Management Platform
https://manageiq.org
Apache License 2.0
1.35k stars 899 forks source link

SSA not possible on RHV datastores depending on the navigation path taken when navigating to it #20367

Open jarovo opened 4 years ago

jarovo commented 4 years ago

Description of problem:

Starting the SmartState Analysis is not handled in consistent way across providers.

From All datastores page

Compute -> Infrastructure -> Datastores; [Select one RHV DS from the list], [Click on Configure -> Start SSA]

The button for starting the analysis of datastore on RHV providers is enabled, but the start is not sucesfull with message: "SmartState Analysis action does not apply to selected items". On vmware provider, the SSA starts fine.

From Provider datastores page

Compute -> Infrastructure -> Providers; [Select RHV provider], [Select Datastores], [Check one DS from the list], [Click on Configure -> Start SSA]

The SSA starts on datastore of both -- vmware as well as RHV. Message ... scan successfully initiated when trying from the datastore Details page" is displayed.

From Datastore Details page:

Compute -> Infrastructure -> Providers; [Select RHV provider], [Select Datastores from the table].

It seems no matter which navigation path is taken, The Configure button is disabled on RHV. It is enabled on vmware and works fine.

Version-Release number of selected component (if applicable):

5.11.6.0.20200526234234_3fcafeb 5.11.7.0.20200714215453_0da8a4

How reproducible:

1/1 For each CFME version noted. It is important to note that when vmware provider is deleted, some items are archived, which can manifest as duplicated items (datastores for example) and that may cause a confusion.

Steps to Reproduce:

  1. Add a RHV and vmware provider
  2. Go to datastore trough provider and select it or select some DS from the All datastores page or display Details page of the datastore
  3. Click on button for starting SSA

Actual results:

When not going trough the provider, SSA is not allowed: SmartState Analysis action does not apply to selected items is displayed

Expected results:

Hard to tell what should be expected. The compatibility matrix is not really populated for RHV in the documentation. The behaviour is not consistent even for single CFME version and single provider.

https://bugzilla.redhat.com/show_bug.cgi?id=1858107

jerryk55 commented 4 years ago

@jaryn do you have an environment available that I can use to try to reproduce this? Thanks much.

jarovo commented 4 years ago

You can play with one this for a week: https://[PRIVATE_IP_CHECK_EMAIL]/ems_infra/show_list#/

On Mon, Jul 20, 2020 at 9:46 PM Jerry Keselman notifications@github.com wrote:

@jaryn https://github.com/jaryn do you have an environment available that I can use to try to reproduce this? Thanks much.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ManageIQ/manageiq/issues/20367#issuecomment-661296366, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJB3QJVEJNTV5YNQMELAXTR4SNJBANCNFSM4O6RTJMQ .

jerryk55 commented 4 years ago

@jaryn, on the above provided appliance, I would say that datastore SSA is behaving as expected with regard to the "path taken when navigating to it". On the datastores for which SSA is currently "valid", you can start it successfully in both the list view and detail view. On the datastores for which SSA is not valid, in the list view you can make the request, but you will get a popup saying that SSA does not apply for the selected datastore. And if you drill down into the detailed view for that datastore, the SSA operation under Configuration is grayed-out since it does not apply. I don't see any inconsistency between the detail view and the list view.

Now, I can't tell you offhand whether these datastores should actually be scannable - but that is not the purpose of this issue as I read it.

jarovo commented 4 years ago

@jaryn, on the above provided appliance, I would say that datastore SSA is behaving as expected with regard to the "path taken when navigating to it". On the datastores for which SSA is currently "valid", you can start it successfully in both the list view and detail view. On the datastores for which SSA is not valid, in the list view you can make the request, but you will get a popup saying that SSA does not apply for the selected datastore. And if you drill down into the detailed view for that datastore, the SSA operation under Configuration is grayed-out since it does not apply. I don't see any inconsistency between the detail view and the list view.

Now, I can't tell you offhand whether these datastores should actually be scannable - but that is not the purpose of this issue as I read it.

My main issue is the SSA of RHV provider does start when navigating trough the provider, but when selecting the same datastore from All datastores page, it is not possible to start the SSA. So I conclude SSA on RHV is possible. The code enabling the buttons is inconsistent and chooses to disable the SSA starting (Configure) button in some navigation path while chooses to enable starting SSA in other. So this almost certainly is a UI bug, not a SSA bug.

jerryk55 commented 4 years ago

If you get a popup that says "SSA does not apply for the selected datastore", then SSA is not starting. In the list view, since you can select more than one element in the list, I would not think there would be a way to gray out the SSA button, while it is possible in the detail view. This is the precisely the same behavior that is available for VM SSA - for instance on VMware if the VixDIskLib library is not installed - in the list view you can still click on the SSA selection, but not in the detail view.. It has nothing to do with datastores, and has everything to do with the way the web controller operates.

jarovo commented 4 years ago

If you get a popup that says "SSA does not apply for the selected datastore", then SSA is not starting. In the list view, since you can select more than one element in the list, I would not think there would be a way to gray out the SSA button, while it is possible in the detail view. This is the precisely the same behavior that is available for VM SSA - for instance on VMware if the VixDIskLib library is not installed - in the list view you can still click on the SSA selection, but not in the detail view.. It has nothing to do with datastores, and has everything to do with the way the web controller operates.

But I am able to get "scan successfully initiated" displayed. The problem is that only when navigating trough the provider and using checkbox. When on Details page or on All datastores page using checkbox, it is not possible to start the SSA on same datastore.

I am posting a video to the BZ as I don't want to share the IP displayed on it.

jerryk55 commented 4 years ago

Ah. ok. So the real question is - why does SSA appear to work in the provider list when you drill down through the RHEV provider, but not when you go directly to the datastores list. At no point does it work in the detail. Additionally - is it really working? There seems to be alot of data missing for this to be considered successful. Finally - can you provide an environment where you can successfully run SSA on a RHEV datastore? Since I've never even looked at Datastore SSA I'm not sure what a successful run is supposed to look like - other than the VMware datastores visible on this appliance.

jarovo commented 4 years ago

Yeah. I think you just nailed it with the question. I think we have understanding now. I am afraid I am not a good person to ask whether it was successful or not, though as I was already working on something SSA related ( https://github.com/ManageIQ/integration_tests/pull/9646/files#diff-71ae6e1789119fda743f4e984fc90559), I think we can ask Nick Carboni. He was helping me with the PR I just linked.

You mentioned data being missing. What are you looking at? I know there are some counts of VMs and files missing (displays 0). I made an issue about this: https://github.com/ManageIQ/manageiq/issues/20366.

I am afraid I cannot really provide you with something better than what you already have.

On Tue, Jul 21, 2020 at 4:43 PM Jerry Keselman notifications@github.com wrote:

Ah. ok. So the real question is - why does SSA appear to work in the provider list when you drill down through the RHEV provider, but not when you go directly to the datastores list. At no point does it work in the detail. Additionally - is it really working? There seems to be alot of data missing for this to be considered successful. Finally - can you provide an environment where you can successfully run SSA on a RHEV datastore? Since I've never even looked at Datastore SSA I'm not sure what a successful run is supposed to look like - other than the VMware datastores visible on this appliance.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ManageIQ/manageiq/issues/20367#issuecomment-661903795, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJB3QJTV2MFGHHS4YZJR5LR4WSO3ANCNFSM4O6RTJMQ .

-- Insanity: doing the same thing over and over and expecting a different result. Engineering: doing the same thing over and over and hoping for the same result.

jerryk55 commented 4 years ago

Oh I guess I was under the impression that the CFME version was relevant, but now I see you modified that part of the title of this issue. Never mind about another system.

gtanzillo commented 4 years ago

/cc @h-kataria

mzazrivec commented 4 years ago

The problem described here was fixed in upstream a while ago in https://github.com/ManageIQ/manageiq-ui-classic/pull/6224

We have a PR to backport it to ivanchuk: https://github.com/ManageIQ/manageiq-ui-classic/pull/7241

The core of the problem was that we'd run SSA for a completely different (i.e. incorrect) type of object, not for the actual datastore. So yes, this was purely an UI issue and this report here can be closed.