search

ManageIQ / manageiq

ManageIQ Open-Source Management Platform
https://manageiq.org
Apache License 2.0
1.34k stars 897 forks source link

Make provider secrets pluggable #21157

Closed agrare closed 3 years ago

agrare commented 3 years ago

Rails secrets are used by provider plugins to allow for VCR cassettes and refresh spec tests to run without having to contain "secret" values such as internal hostname and credentials. Currently this is all done in core's spec_helper [ref]. The problem with this is it doesn't allow for any customization by the various providers and the replaced values aren't always valid (e.g. AMAZON_HOSTNAME isn't a valid URI).

This also only looks for config/secrets.yml in core with no provision for secrets in each provider plugin.

kbrock commented 3 years ago

all purple - great job for no small feat.

agrare commented 3 years ago

A number of the new providers depend on these pluggable vcr secrets, backporting this to morphy will make the task of backporting these new providers drastically easier. Adding morphy/yes? to these dependent PRs