ManageIQ / manageiq

ManageIQ Open-Source Management Platform
https://manageiq.org
Apache License 2.0
1.35k stars 900 forks source link

Transform VM dialogs related to v2v are still present #21874

Open Fryguy opened 2 years ago

Fryguy commented 2 years ago

Discussed in https://github.com/ManageIQ/manageiq/discussions/21870

This seems to have been missed in the deletion of v2v.


$ ag-miq -i "Transform Vm"
/Users/jfrey/dev/manageiq-ui-service/tests/mock/rbac/allPermissions.json:1061:        "description": "Transform VM"
/Users/jfrey/dev/manageiq-ui-classic/app/controllers/mixins/actions/vm_actions/transform.rb:6:          dialog = Dialog.find_by(:label => 'Transform VM')
/Users/jfrey/dev/manageiq-ui-classic/app/controllers/mixins/actions/vm_actions/transform.rb:8:          @right_cell_text = _("Transform VM %{name} to RHV") % {:name => vm.name}
/Users/jfrey/dev/manageiq-ui-classic/app/controllers/mixins/actions/provider_actions/mass_transform.rb:6:          dialog = Dialog.find_by!(:label => 'Transform VM')
/Users/jfrey/dev/manageiq-ui-classic/app/controllers/mixins/actions/provider_actions/mass_transform.rb:7:          @right_cell_text = _("Transform VMs to RHV")
/Users/jfrey/dev/manageiq-ui-classic/app/controllers/vm_common.rb:1103:    %w[vm_transform vm_transform_mass].include?(params[:pressed])
/Users/jfrey/dev/manageiq-ui-classic/app/helpers/application_helper/button/transform_vm_button.rb:10:    @error_message = _('Can only transform VMs in down state') unless vm_down?
/Users/jfrey/dev/manageiq-ui-classic/app/helpers/application_helper/button/transform_vm_button.rb:11:    @error_message = _('Cannot transform VMs with snapshots') if vm_has_snapshots?
/Users/jfrey/dev/manageiq-ui-classic/spec/controllers/vm_infra_controller_spec.rb:448:  context 'transform VM dialog' do
/Users/jfrey/dev/manageiq-ui-classic/spec/controllers/vm_infra_controller_spec.rb:449:    let(:dialog)           { FactoryBot.create(:dialog, :label => 'Transform VM', :buttons => 'submit') }
/Users/jfrey/dev/manageiq/db/fixtures/miq_product_features.yml:5846:        :description: Transform VM
/Users/jfrey/dev/manageiq-providers-ovirt/CHANGELOG.md:128:- Set default tag category in 'Transform VM' dialog [(#135)](https://github.com/ManageIQ/manageiq-providers-ovirt/pull/135)
miq-bot commented 1 year ago

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

Fryguy commented 1 year ago

@MelsHyrule Can you verify if this is still a thing? If so, let's see if we can get this all deleted, as it might help with some of the angular stuff.

miq-bot commented 1 year ago

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

Fryguy commented 1 year ago

This may only appear on upgrades; not sure.

miq-bot commented 1 year ago

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.