ManageIQ / manageiq

ManageIQ Open-Source Management Platform
https://manageiq.org
Apache License 2.0
1.34k stars 897 forks source link

[Providers] Replace `InventoryRefresh::InventoryCollection#find` with `#lazy_find` #22051

Open agrare opened 1 year ago

agrare commented 1 year ago

The #find method introduces a dependency ordering issue during full refresh and a potential missing data issue during targeted refresh and should be replaced by #lazy_find wherever possible.

This method will be removed in an upcoming release of the inventory_refresh gem

changes in inventory_refresh: https://github.com/ManageIQ/inventory_refresh/pull/112

Fryguy commented 1 year ago

Is this done @agrare ?

agrare commented 1 year ago

No there are still some tougher ones left, I'll add the rest to the checklist so we can see the progress

miq-bot commented 1 year ago

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

miq-bot commented 1 year ago

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.