search

ManageIQ / manageiq

ManageIQ Open-Source Management Platform
https://manageiq.org
Apache License 2.0
1.35k stars 896 forks source link

Use config.load_defaults for rails 7 with overrides #23176

Open jrafanie opened 3 weeks ago

jrafanie commented 3 weeks ago

As far as I can see, belongs_to_required_by_default, is the only override in load_defaults that we manually override. See: https://github.com/rails/rails/blob/d437ae311f1b9dc40b442e40eb602e020cec4e49/railties/lib/rails/application/configuration.rb#L92

This change makes the override explicit.

Fixes #23172

jrafanie commented 3 weeks ago

@miq-bot cross-repo-tests /all

jrafanie commented 3 weeks ago

I'm looking at cross repo failures

manageiq-content ``` 1) Quota Validation VmReconfig quota request removes a disk Failure/Error: MiqAeEngine.instantiate("/ManageIQ/system/request/Call_Instance?namespace=System/CommonMethods&" \ "class=QuotaMethods&instance=requested&#{attrs.join('&')}", @user) MiqAeException::UnknownMethodRc: Method exited with rc=Unknown RC: [1] # /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq@cbda86404ed4f777beef430ef939df36ce8d6de5/app/models/user.rb:383:in `with_user' # ./spec/automation/unit/method_validation/requested_spec.rb:6:in `run_automate_method' # ./spec/automation/unit/method_validation/requested_spec.rb:265:in `block (3 levels) in ' 2) Quota Validation VmReconfig quota request no change Failure/Error: MiqAeEngine.instantiate("/ManageIQ/system/request/Call_Instance?namespace=System/CommonMethods&" \ "class=QuotaMethods&instance=requested&#{attrs.join('&')}", @user) MiqAeException::UnknownMethodRc: Method exited with rc=Unknown RC: [1] # /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq@cbda86404ed4f777beef430ef939df36ce8d6de5/app/models/user.rb:383:in `with_user' # ./spec/automation/unit/method_validation/requested_spec.rb:6:in `run_automate_method' # ./spec/automation/unit/method_validation/requested_spec.rb:289:in `block (3 levels) in ' 3) Quota Validation VmReconfig quota request minus 1 cpu and minus 2048 memory Failure/Error: MiqAeEngine.instantiate("/ManageIQ/system/request/Call_Instance?namespace=System/CommonMethods&" \ "class=QuotaMethods&instance=requested&#{attrs.join('&')}", @user) MiqAeException::UnknownMethodRc: Method exited with rc=Unknown RC: [1] # /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq@cbda86404ed4f777beef430ef939df36ce8d6de5/app/models/user.rb:383:in `with_user' # ./spec/automation/unit/method_validation/requested_spec.rb:6:in `run_automate_method' # ./spec/automation/unit/method_validation/requested_spec.rb:281:in `block (3 levels) in ' 4) Quota Validation VmReconfig quota request resize 10 to 20 megabyte disk, difference is 10 Failure/Error: MiqAeEngine.instantiate("/ManageIQ/system/request/Call_Instance?namespace=System/CommonMethods&" \ "class=QuotaMethods&instance=requested&#{attrs.join('&')}", @user) MiqAeException::UnknownMethodRc: Method exited with rc=Unknown RC: [1] # /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq@cbda86404ed4f777beef430ef939df36ce8d6de5/app/models/user.rb:383:in `with_user' # ./spec/automation/unit/method_validation/requested_spec.rb:6:in `run_automate_method' # ./spec/automation/unit/method_validation/requested_spec.rb:249:in `block (3 levels) in ' 5) Quota Validation VmReconfig quota request add 2 cpus and add 4096 memory Failure/Error: MiqAeEngine.instantiate("/ManageIQ/system/request/Call_Instance?namespace=System/CommonMethods&" \ "class=QuotaMethods&instance=requested&#{attrs.join('&')}", @user) MiqAeException::UnknownMethodRc: Method exited with rc=Unknown RC: [1] # /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq@cbda86404ed4f777beef430ef939df36ce8d6de5/app/models/user.rb:383:in `with_user' # ./spec/automation/unit/method_validation/requested_spec.rb:6:in `run_automate_method' # ./spec/automation/unit/method_validation/requested_spec.rb:240:in `block (3 levels) in ' 6) Auto Approval Request Validation exceed memory Failure/Error: let(:ws) { MiqAeEngine.instantiate("/System/Request/Call_Method?#{method}&#{args}&#{@value}", @user) } MiqAeException::UnknownMethodRc: Method exited with rc=Unknown RC: [1] # /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq@cbda86404ed4f777beef430ef939df36ce8d6de5/app/models/user.rb:383:in `with_user' # ./spec/automation/unit/method_validation/validate_request_spec.rb:3:in `block (2 levels) in ' # ./spec/automation/unit/method_validation/validate_request_spec.rb:29:in `block (2 levels) in ' 7) Quota Validation Provisioning failure warn memory behaves like check_quota for Provisioning check Failure/Error: MiqAeEngine.instantiate("/ManageIQ/system/request/Call_Instance?namespace=System/CommonMethods&" \ "class=QuotaMethods&instance=validate_quota&#{attrs.join('&')}", @user) MiqAeException::UnknownMethodRc: Method exited with rc=Unknown RC: [1] Shared Example Group: "check_quota for Provisioning" called from ./spec/automation/unit/method_validation/validate_quota_spec.rb:101 # /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq@cbda86404ed4f777beef430ef939df36ce8d6de5/app/models/user.rb:383:in `with_user' # ./spec/automation/unit/method_validation/validate_quota_spec.rb:13:in `run_automate_method' # ./spec/automation/unit/method_validation/validate_quota_spec.rb:36:in `block (4 levels) in ' 8) Quota Validation Provisioning failure max memory behaves like check_quota for Provisioning check Failure/Error: MiqAeEngine.instantiate("/ManageIQ/system/request/Call_Instance?namespace=System/CommonMethods&" \ "class=QuotaMethods&instance=validate_quota&#{attrs.join('&')}", @user) MiqAeException::UnknownMethodRc: Method exited with rc=Unknown RC: [1] Shared Example Group: "check_quota for Provisioning" called from ./spec/automation/unit/method_validation/validate_quota_spec.rb:59 # /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq@cbda86404ed4f777beef430ef939df36ce8d6de5/app/models/user.rb:383:in `with_user' # ./spec/automation/unit/method_validation/validate_quota_spec.rb:13:in `run_automate_method' # ./spec/automation/unit/method_validation/validate_quota_spec.rb:36:in `block (4 levels) in ' 9) Quota Validation Provisioning failure max storage behaves like check_quota for Provisioning check Failure/Error: MiqAeEngine.instantiate("/ManageIQ/system/request/Call_Instance?namespace=System/CommonMethods&" \ "class=QuotaMethods&instance=validate_quota&#{attrs.join('&')}", @user) MiqAeException::UnknownMethodRc: Method exited with rc=Unknown RC: [1] Shared Example Group: "check_quota for Provisioning" called from ./spec/automation/unit/method_validation/validate_quota_spec.rb:69 # /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq@cbda86404ed4f777beef430ef939df36ce8d6de5/app/models/user.rb:383:in `with_user' # ./spec/automation/unit/method_validation/validate_quota_spec.rb:13:in `run_automate_method' # ./spec/automation/unit/method_validation/validate_quota_spec.rb:36:in `block (4 levels) in ' 10) Quota Validation Provisioning failure warn storage behaves like check_quota for Provisioning check Failure/Error: MiqAeEngine.instantiate("/ManageIQ/system/request/Call_Instance?namespace=System/CommonMethods&" \ "class=QuotaMethods&instance=validate_quota&#{attrs.join('&')}", @user) MiqAeException::UnknownMethodRc: Method exited with rc=Unknown RC: [1] Shared Example Group: "check_quota for Provisioning" called from ./spec/automation/unit/method_validation/validate_quota_spec.rb:137 # /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq@cbda86404ed4f777beef430ef939df36ce8d6de5/app/models/user.rb:383:in `with_user' # ./spec/automation/unit/method_validation/validate_quota_spec.rb:13:in `run_automate_method' # ./spec/automation/unit/method_validation/validate_quota_spec.rb:36:in `block (4 levels) in ' 11) Quota Validation Reconfigure failure max memory behaves like check_quota for Reconfigure check Failure/Error: MiqAeEngine.instantiate("/ManageIQ/system/request/Call_Instance?namespace=System/CommonMethods&" \ "class=QuotaMethods&instance=validate_quota&#{attrs.join('&')}", @user) MiqAeException::UnknownMethodRc: Method exited with rc=Unknown RC: [1] Shared Example Group: "check_quota for Reconfigure" called from ./spec/automation/unit/method_validation/validate_quota_spec.rb:199 # /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq@cbda86404ed4f777beef430ef939df36ce8d6de5/app/models/user.rb:383:in `with_user' # ./spec/automation/unit/method_validation/validate_quota_spec.rb:13:in `run_automate_method' # ./spec/automation/unit/method_validation/validate_quota_spec.rb:156:in `block (4 levels) in ' 12) Quota Validation Reconfigure failure max storage behaves like check_quota for Reconfigure check Failure/Error: MiqAeEngine.instantiate("/ManageIQ/system/request/Call_Instance?namespace=System/CommonMethods&" \ "class=QuotaMethods&instance=validate_quota&#{attrs.join('&')}", @user) MiqAeException::UnknownMethodRc: Method exited with rc=Unknown RC: [1] Shared Example Group: "check_quota for Reconfigure" called from ./spec/automation/unit/method_validation/validate_quota_spec.rb:211 # /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq@cbda86404ed4f777beef430ef939df36ce8d6de5/app/models/user.rb:383:in `with_user' # ./spec/automation/unit/method_validation/validate_quota_spec.rb:13:in `run_automate_method' # ./spec/automation/unit/method_validation/validate_quota_spec.rb:156:in `block (4 levels) in ' 13) ManageIQ::Automate::System::CommonMethods::QuotaMethods::Used returns ok for user counts behaves like used check Failure/Error: described_class.new(ae_service).main TypeError: no implicit conversion of Symbol into Integer Shared Example Group: "used" called from ./spec/content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used_spec.rb:59 # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:25:in `to_s' # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:25:in `used' # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:18:in `main' # ./spec/content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used_spec.rb:41:in `block (3 levels) in ' 14) ManageIQ::Automate::System::CommonMethods::QuotaMethods::Used Owner email Owner email only returns ok behaves like used user quota check Failure/Error: described_class.new(ae_service).main TypeError: no implicit conversion of Symbol into Integer Shared Example Group: "used user quota" called from ./spec/content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used_spec.rb:96 # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:25:in `to_s' # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:25:in `used' # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:18:in `main' # ./spec/content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used_spec.rb:83:in `block (4 levels) in ' 15) ManageIQ::Automate::System::CommonMethods::QuotaMethods::Used Owner email Requester email only returns ok behaves like used user quota check Failure/Error: described_class.new(ae_service).main TypeError: no implicit conversion of Symbol into Integer Shared Example Group: "used user quota" called from ./spec/content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used_spec.rb:89 # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:25:in `to_s' # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:25:in `used' # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:18:in `main' # ./spec/content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used_spec.rb:83:in `block (4 levels) in ' 16) ManageIQ::Automate::System::CommonMethods::QuotaMethods::Used Owner email Requester and Owner email returns ok behaves like used user quota check Failure/Error: described_class.new(ae_service).main TypeError: no implicit conversion of Symbol into Integer Shared Example Group: "used user quota" called from ./spec/content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used_spec.rb:102 # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:25:in `to_s' # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:25:in `used' # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:18:in `main' # ./spec/content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used_spec.rb:83:in `block (4 levels) in ' 17) ManageIQ::Automate::System::CommonMethods::QuotaMethods::Used returns error when no quota source type Failure/Error: expect { described_class.new(ae_service).main }.to raise_error(errormsg) expected Exception with "ERROR - quota_source_type not found", got # with backtrace: # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:25:in `to_s' # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:25:in `used' # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:18:in `main' # ./spec/content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used_spec.rb:124:in `block (4 levels) in ' # ./spec/content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used_spec.rb:124:in `block (3 levels) in ' # ./spec/content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used_spec.rb:124:in `block (3 levels) in ' 18) ManageIQ::Automate::System::CommonMethods::QuotaMethods::Used returns error when no owner or requester email Failure/Error: expect { described_class.new(ae_service).main }.to raise_error(errormsg) expected Exception with "ERROR - Owner email not specified for User Quota", got # with backtrace: # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:25:in `to_s' # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:25:in `used' # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:18:in `main' # ./spec/content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used_spec.rb:114:in `block (4 levels) in ' # ./spec/content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used_spec.rb:114:in `block (3 levels) in ' # ./spec/content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used_spec.rb:114:in `block (3 levels) in ' 19) ManageIQ::Automate::System::CommonMethods::QuotaMethods::Used returns ok for tenant counts behaves like used check Failure/Error: described_class.new(ae_service).main TypeError: no implicit conversion of Symbol into Integer Shared Example Group: "used" called from ./spec/content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used_spec.rb:51 # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:25:in `to_s' # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:25:in `used' # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:18:in `main' # ./spec/content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used_spec.rb:41:in `block (3 levels) in ' 20) ManageIQ::Automate::System::CommonMethods::QuotaMethods::Used returns ok for group counts behaves like used check Failure/Error: described_class.new(ae_service).main TypeError: no implicit conversion of Symbol into Integer Shared Example Group: "used" called from ./spec/content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used_spec.rb:67 # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:25:in `to_s' # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:25:in `used' # ./content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used.rb:18:in `main' # ./spec/content/automate/ManageIQ/System/CommonMethods/QuotaMethods.class/__methods__/used_spec.rb:41:in `block (3 levels) in ' ```
manageiq-providers-amazon ``` 1) ManageIQ::Providers::Amazon::StorageManager::S3::Refresher destructive operations (objects) remove object (process) Failure/Error: if key.end_with? "/" # delete object with subobjects (aka. folder) NoMethodError: undefined method `end_with?' for nil:NilClass # ./app/models/manageiq/providers/amazon/storage_manager/s3/cloud_object_store_object.rb:19:in `raw_delete' # /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq@cbda86404ed4f777beef430ef939df36ce8d6de5/app/models/cloud_object_store_object/operations.rb:5:in `cloud_object_store_object_delete' # ./spec/models/manageiq/providers/amazon/storage_manager/s3/stubbed_refresher_spec.rb:229:in `block (5 levels) in ' # ./spec/models/manageiq/providers/amazon/storage_manager/s3/stubbed_refresher_spec.rb:229:in `block (4 levels) in ' # ./spec/models/manageiq/providers/amazon/aws_helper.rb:11:in `with_aws_stubbed' # ./spec/models/manageiq/providers/amazon/storage_manager/s3/stubbed_refresher_spec.rb:227:in `block (3 levels) in ' 2) ManageIQ::Providers::Amazon::StorageManager::S3::Refresher destructive operations (objects) object delete triggers remote deletion Failure/Error: if key.end_with? "/" # delete object with subobjects (aka. folder) NoMethodError: undefined method `end_with?' for nil:NilClass # ./app/models/manageiq/providers/amazon/storage_manager/s3/cloud_object_store_object.rb:19:in `raw_delete' # /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq@cbda86404ed4f777beef430ef939df36ce8d6de5/app/models/cloud_object_store_object/operations.rb:5:in `cloud_object_store_object_delete' # ./spec/models/manageiq/providers/amazon/storage_manager/s3/stubbed_refresher_spec.rb:216:in `block (4 levels) in ' # ./spec/models/manageiq/providers/amazon/aws_helper.rb:11:in `with_aws_stubbed' # ./spec/models/manageiq/providers/amazon/storage_manager/s3/stubbed_refresher_spec.rb:215:in `block (3 levels) in ' 3) ManageIQ::Providers::Amazon::StorageManager::S3::Refresher destructive operations (objects) objects's provider_object is of expected type Failure/Error: cloud_object_store_container.provider_object(connection).object(key) ArgumentError: missing required option :key # ./app/models/manageiq/providers/amazon/storage_manager/s3/cloud_object_store_object.rb:15:in `provider_object' # ./spec/models/manageiq/providers/amazon/storage_manager/s3/stubbed_refresher_spec.rb:205:in `block (4 levels) in ' # ./spec/models/manageiq/providers/amazon/aws_helper.rb:11:in `with_aws_stubbed' # ./spec/models/manageiq/providers/amazon/storage_manager/s3/stubbed_refresher_spec.rb:204:in `block (3 levels) in ' ``` Seems to be caused by [active_record.partial_inserts = false](https://github.com/rails/rails/blob/d437ae311f1b9dc40b442e40eb602e020cec4e49/railties/lib/rails/application/configuration.rb#L263)
manageiq-ui-classic ``` 1) SecurityGroupHelper::TextualSummary.textual_group_firewall returns TextualTable struct with list of of firewall rules Failure/Error: rule.port_range.to_s(:dash) ArgumentError: wrong number of arguments (given 1, expected 0) # ./app/helpers/security_group_helper/textual_summary.rb:105:in `to_s' # ./app/helpers/security_group_helper/textual_summary.rb:105:in `port_range_helper' # ./app/helpers/security_group_helper/textual_summary.rb:44:in `block in textual_group_firewall' # ./app/helpers/security_group_helper/textual_summary.rb:39:in `collect' # ./app/helpers/security_group_helper/textual_summary.rb:39:in `textual_group_firewall' # ./spec/helpers/security_group_helper/textual_summary_spec.rb:7:in `block (3 levels) in ' # ./spec/helpers/security_group_helper/textual_summary_spec.rb:14:in `block (3 levels) in ' ```
jrafanie commented 3 weeks ago

I'm testing this using this in my config/application.rb.

click me "SAMEORIGIN", "X-XSS-Protection" => "0", "X-Content-Type-Options" => "nosniff", "X-Download-Options" => "noopen", "X-Permitted-Cross-Domain-Policies" => "none", "Referrer-Policy" => "strict-origin-when-cross-origin" } # 2 # config.action_dispatch.return_only_request_media_type_on_content_type = true config.action_dispatch.return_only_request_media_type_on_content_type = false # 3 # config.action_dispatch.cookies_serializer = nil config.action_dispatch.cookies_serializer = :json # 4 # config.action_view.button_to_generates_button_tag = nil config.action_view.button_to_generates_button_tag = true # 5 # config.action_view.apply_stylesheet_media_default = true config.action_view.apply_stylesheet_media_default = false # 6 # config.active_support.hash_digest_class = OpenSSL::Digest::SHA1 config.active_support.hash_digest_class = OpenSSL::Digest::SHA256 # 7 # config.active_support.key_generator_hash_digest_class = nil config.active_support.key_generator_hash_digest_class = OpenSSL::Digest::SHA256 # 8 # config.active_support.remove_deprecated_time_with_zone_name = nil config.active_support.remove_deprecated_time_with_zone_name = true # 9 # config.active_support.cache_format_version = nil config.active_support.cache_format_version = 7.0 # 10 # config.active_support.use_rfc4122_namespaced_uuids = nil config.active_support.use_rfc4122_namespaced_uuids = true # 11 # config.active_support.executor_around_test_case = nil config.active_support.executor_around_test_case = true # 12 # config.active_support.disable_to_s_conversion = false config.active_support.disable_to_s_conversion = true # 13 # config.action_mailer.smtp_timeout = nil config.action_mailer.smtp_timeout = 5 # 14 # config.active_record.verify_foreign_keys_for_fixtures = nil config.active_record.verify_foreign_keys_for_fixtures = true # 15 # config.active_record.partial_inserts = nil config.active_record.partial_inserts = false # 16 # config.active_record.automatic_scope_inversing = nil config.active_record.automatic_scope_inversing = true # 17 # config.action_controller.raise_on_open_redirects = false config.action_controller.raise_on_open_redirects = true # 18 # config.action_controller.wrap_parameters_by_default = false config.action_controller.wrap_parameters_by_default = true ``` That's from [here](https://github.com/rails/rails/blob/d437ae311f1b9dc40b442e40eb602e020cec4e49/railties/lib/rails/application/configuration.rb#L233C13-L323C14). Only active storage is unconfigured so no need to test.
jrafanie commented 1 week ago

config.action_dispatch.return_only_request_media_type_on_content_type = false

https://www.github.com/rails/rails/pull/36946 https://www.github.com/rails-api/active_model_serializers/pull/2340 "Rails 6 changes the default behavior of ActionDispatch::Response#content_type, which now returns the Content-Type header as it is."

config.action_dispatch.cookies_serializer = :json Previously was marshal if you didn't specify it in a serializer. I think this should be ok. https://www.github.com/rails/rails/pull/42538 https://www.github.com/rails/rails/pull/45172

config.action_view.button_to_generates_button_tag = true determines whether button_to will render <button> element, regardless of whether or not the content is passed as the first argument or as a block. https://www.github.com/rails/rails/pull/41055

miq-bot commented 1 week ago

Checked commits https://github.com/jrafanie/manageiq/compare/f7395d4185940ebabb660a4a43f2587557e1a5e2~...a393d4af01d6df703711e64510926181c699e6b4 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 2 files checked, 2 offenses detected

config/application.rb

config/initializers/secure_headers.rb