Ignore brakeman progress on CI (non-tty)

Fryguy commented 2 months ago

On CI, we get every progress update line-by-line and it overwhelms the output. More specifically, since CI doesn't have a tty, we can use that as a more accurate indicator.

Before:

Processing libs...                    
 0/2080 files processed
 1/2080 files processed
 2/2080 files processed
 3/2080 files processed
 4/2080 files processed
 5/2080 files processed
 6/2080 files processed
 7/2080 files processed
... (2000+ more lines of output)
Processing routes...                  
Processing templates...               
 0/1638 templates processed
 1/1638 templates processed
 2/1638 templates processed
 3/1638 templates processed
 4/1638 templates processed
... (1600+ more lines of output)

After:

Processing libs...                    
Processing routes...                  
Processing templates...

miq-bot commented 2 months ago

Checked commit https://github.com/Fryguy/manageiq/commit/d4774a0f7b0bca79d73e7ee1cd4c720ef20efd45 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :cookie:

Fryguy commented 2 months ago

@jrafanie You can see the nicer output here: https://github.com/ManageIQ/manageiq/actions/runs/10800285274/job/29957923025?pr=23181#step:8:65

I can also confirm that locally I see the progress indicators.

jrafanie commented 2 months ago

@jrafanie You can see the nicer output here: https://github.com/ManageIQ/manageiq/actions/runs/10800285274/job/29957923025?pr=23181#step:8:65

😍 😍 😍 Good idea. It looks SO much better.

ManageIQ / manageiq

Ignore brakeman progress on CI (non-tty) #23181