search

ManageIQ / manageiq

ManageIQ Open-Source Management Platform
https://manageiq.org
Apache License 2.0
1.35k stars 896 forks source link

Require uuidtools in MiqServer::EnvironmentManager #23184

Closed agrare closed 2 weeks ago

agrare commented 2 weeks ago

Prevent NameError uninitialized constant UUIDTools during MiqServer startup

This wasn't a new call, but I'm guessing when we dropped the LinuxAdmin require here 71fb7d24da80b1d0297183b54ec32cb8d7fff3c6 / https://github.com/ManageIQ/manageiq/pull/23118#issuecomment-2260591465 it caused this to fail sometimes.

INFO -- evm: MIQ(EvmServer#impersonate_server) Impersonating server - id: 1, guid: 421b8269-4509-4897-b600-b577940837eb
WARN -- evm: MIQ(MiqServer.get_network_information) Failed to get network information: uninitialized constant MiqServer::EnvironmentManagement::ClassMethods::UUIDTools
        mac_address = UUIDTools::UUID.mac_address.dup
                      ^^^^^^^^^
ERROR -- evm: [NameError]: uninitialized constant MiqServer::EnvironmentManagement::ClassMethods::UUIDTools
        mac_address = UUIDTools::UUID.mac_address.dup
                      ^^^^^^^^^  Method:[block (2 levels) in <class:LogProxy>]
ERROR -- evm: /var/www/miq/vmdb/app/models/miq_server/environment_management.rb:11:in `get_network_information'
  /var/www/miq/vmdb/lib/workers/evm_server.rb:166:in `save_local_network_info'
  /var/www/miq/vmdb/lib/workers/evm_server.rb:109:in `start_server'
  /var/www/miq/vmdb/lib/workers/evm_server.rb:45:in `block in start_servers'
  /var/www/miq/vmdb/lib/workers/evm_server.rb:273:in `block in as_each_server'
  /var/www/miq/vmdb/lib/workers/evm_server.rb:271:in `each'
  /var/www/miq/vmdb/lib/workers/evm_server.rb:271:in `as_each_server'/var/www/miq/vmdb/lib/workers/evm_server.rb:45:in `start_servers'
  /var/www/miq/vmdb/lib/workers/evm_server.rb:30:in `start'
  /var/www/miq/vmdb/lib/workers/evm_server.rb:84:in `start'
  lib/workers/bin/evm_server.rb:4:in `<main>'
INFO -- evm: MIQ(EvmServer#log_server_info) Server IP Address: 10.2.2.24
INFO -- evm: MIQ(EvmServer#log_server_info) Server Hostname: manageiq.rb.nj.grare.com
INFO -- evm: MIQ(EvmServer#log_server_info) Server MAC Address: 52:54:00:e8:67:81
miq-bot commented 2 weeks ago

Checked commit https://github.com/agrare/manageiq/commit/1aa1b27de2b7217ac2b887493334866bf86899e8 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :cookie: