search

ManageIQ / manageiq

ManageIQ Open-Source Management Platform
https://manageiq.org
Apache License 2.0
1.35k stars 900 forks source link

Replace Container ENV var EMS_IDS->_ID #23195

Closed agrare closed 2 months ago

agrare commented 2 months ago

Workers having a comma separated list of EMS IDs has been replaced with moving child-manager refresh logic into the parent-manager refresher.

I noticed this while investigating the OpentofuWorker, it is also odd that deployment-per-worker also assumes that it is an EMS worker which isn't necessarily the case.

I think a better approach would be to move the environment variable logic out of how the workers are managed by kubernetes, and unify it with how systemd handles environment variables per-worker with the unit_environment_variables method (which already handles EMS_ID).

Co-depends:

miq-bot commented 2 months ago

Checked commit https://github.com/agrare/manageiq/commit/41d5fad22468afb3ea1b7fc4574f0237d99cafb2 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :trophy:

agrare commented 2 months ago

Ha yeah I keep finding more, I think this is the last of them though (famous last words)