ManageIQ / manageiq

ManageIQ Open-Source Management Platform
https://manageiq.org
Apache License 2.0
1.35k stars 900 forks source link

Fix issue where an engine could be nested in another engine #23196

Closed Fryguy closed 2 months ago

Fryguy commented 2 months ago

Solve this by ensuring when we enumerate the engines we look at deeper engines first.

@jrafanie Please review.

This PR also changes the stubbing of the Rails Engines paths a little higher so we can exercise more of the code in rails_engines_paths.

miq-bot commented 2 months ago

Checked commit https://github.com/Fryguy/manageiq/commit/e6132025fd3936dd6c2b035186247903264497c8 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 2 files checked, 3 offenses detected

spec/lib/extensions/brakeman_fingerprint_patch_spec.rb

Fryguy commented 2 months ago

@jrafanie I rekicked manageiq-api - run is here: https://github.com/ManageIQ/manageiq-api/actions/runs/10949539587

jrafanie commented 2 months ago

image

🎉