ManageIQ / manageiq

ManageIQ Open-Source Management Platform
https://manageiq.org
Apache License 2.0
1.35k stars 898 forks source link

Fix evm_application_spec parallel spec failure #23198

Closed agrare closed 1 month ago

agrare commented 1 month ago

Fix the .deployment_status failure when running in parallel. When running rake parallel:spec this test would reliably fail.

Failures:

  1) EvmApplication.deployment_status with a seeded server returns redeployment otherwise
     Failure/Error: expect(described_class.deployment_status).to eq("redeployment")

       expected: "redeployment"
            got: "upgrade"

       (compared using ==)
     # ./spec/lib/tasks/evm_application_spec.rb:334:in `block (4 levels) in <main>'
     # /home/grare/adam/.gem/ruby/3.1.0/gems/webmock-3.23.1/lib/webmock/rspec.rb:39:in `block (2 levels) in <main>'

Finished in 12.11 seconds (files took 6.64 seconds to load)
164 examples, 1 failure

Failed examples:

rspec ./spec/lib/tasks/evm_application_spec.rb:333 # EvmApplication.deployment_status with a seeded server returns redeployment otherwise
miq-bot commented 1 month ago

Checked commit https://github.com/agrare/manageiq/commit/21e9abff4d96b7177002254e4b48377a074862e5 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 1 file checked, 1 offense detected

spec/lib/tasks/evm_application_spec.rb

kbrock commented 1 month ago

marking as radjabov yes due to the sporadic bug nature. But not strictly necessary

Fryguy commented 1 month ago

Backported to radjabov in commit dbd30144886fa0765b6ef4b20c13a446fd90f482.

commit dbd30144886fa0765b6ef4b20c13a446fd90f482
Author: Keenan Brock <keenan@thebrocks.net>
Date:   Fri Sep 20 15:04:41 2024 -0400

    Merge pull request #23198 from agrare/fix_evm_application_spec_parallel

    Fix evm_application_spec parallel spec failure

    (cherry picked from commit ac7334bf777e8662c6b9206b3a4931487ef0ff66)