Upgrade fast_gettext - Githubissues

ManageIQ / manageiq

ManageIQ Open-Source Management Platform

https://manageiq.org

Apache License 2.0

1.35k stars 900 forks source link

Upgrade fast_gettext #23205

Closed kbrock closed 2 months ago

kbrock commented 2 months ago

This is for ruby 3.2

miq-bot commented 2 months ago

Checked commit https://github.com/kbrock/manageiq/commit/2b2f5cfc56ad7e6c57d2c6d2ee02a04b3475db2b with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :trophy:

kbrock commented 2 months ago

update:

removed ci.yml change
upgraded gettext to latest version. (reviewed documentation and the changes are minor. They dropped ruby 2.x, hence the major upgrade version

jrafanie commented 2 months ago

LGTM - @jrafanie can you verify that your locale stuff still works with this? I want to say we have tests around the locale stuff, but I'm not 100% sure.

We have basic po validation on syntax errors and similar. We also have the locale all github action but that can only run against the branches on ManageIQ.

I think you can run locale:all locally. I vaguelly recall you need to have the db for i18n:

i18n:
  <<: *base
  database: vmdb_i18n

Then you should be able to run bundle exec rake locale:update_all. I'll pull down this branch and try it.

jrafanie commented 2 months ago

Then you should be able to run bundle exec rake locale:update_all. I'll pull down this branch and try it.

It works for me. Considering the changes are minor and mostly due to dropping some old rubies, I think it's safe to update this.