Use rails 7 cache format as 7 can read either 6 or 7

ManageIQ / manageiq

ManageIQ Open-Source Management Platform

https://manageiq.org

Apache License 2.0

1.35k stars 898 forks source link

Use rails 7 cache format as 7 can read either 6 or 7 #23210

Closed jrafanie closed 1 month ago

jrafanie commented 1 month ago

See: https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#new-activesupport-cache-serialization-format

Extracted from https://github.com/ManageIQ/manageiq/pull/23176

miq-bot commented 1 month ago

Checked commit https://github.com/jrafanie/manageiq/commit/7838a74b5c3f6d987c62bfa8b1f588f69b3870bb with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 1 file checked, 1 offense detected

config/application.rb

[x] :warning: - Line 128, Col 157 - Lint/FloatComparison - Avoid (in)equality comparisons of floats as they are unreliable.

Fryguy commented 1 month ago

Not sure if the rubocop is important or not

kbrock commented 1 month ago

Huh. I wonder what class is there - if it is a Version or something

Maybe ask if the version < 7.1 ?

jrafanie commented 1 month ago

Huh. I wonder what class is there - if it is a Version or something

Maybe ask if the version < 7.1 ?

It's a float. It's worrying about precision in case you do math operations. This is a straight comparison with a fixed float so I think we can ignore it. Let me kick the failing sporadic auth failure.

jrafanie commented 1 month ago

Ok, this is ready to go.