simplify fix_auth tests

ManageIQ / manageiq

ManageIQ Open-Source Management Platform

https://manageiq.org

Apache License 2.0

1.35k stars 900 forks source link

simplify fix_auth tests #23212

Closed kbrock closed 1 month ago

kbrock commented 1 month ago

There is an issue in the way that encryption keys work. You can sometimes decrypt a string that has been encoded with a different passkey. You will get the wrong value out, but the system thinks that it succeeded.

Even though the odds of this are very low, since we run managiq so many times, we run across it as a sporadic test failure.

This is an issue and we're removing the offending tests. This functionality is tested in the manageiq-password gem.

Fryguy commented 1 month ago

Not saying we shouldn't merge but would it be better to keep the tests and just mark them as pending or xit?

Fryguy commented 1 month ago

also I'm surprised at the removal of some of these - I wouldn't have expected blank column to need to be removed, for example

kbrock commented 1 month ago

update:

rebased
put most tests back and dropped stubbing. Just doing that one test

kbrock commented 1 month ago

kicking

kbrock commented 1 month ago

update:

rebase
kicking (looks like a quota limit. retrying)

miq-bot commented 1 month ago

Checked commit https://github.com/kbrock/manageiq/commit/d2c808f99edb5791dae3c242a099248822df4bbc with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :star:

Fryguy commented 1 month ago

Backported to radjabov in commit c8228e0e82811060bc90643207d3ad6875e23ade.

commit c8228e0e82811060bc90643207d3ad6875e23ade
Author: Jason Frey <fryguy9@gmail.com>
Date:   Mon Sep 30 13:08:56 2024 -0400

    Merge pull request #23212 from kbrock/fix_auth

    simplify fix_auth tests

    (cherry picked from commit d9352e835f1c255dbf10ebce787b96a0a2a2ad92)