search

ManageIQ / manageiq

ManageIQ Open-Source Management Platform
https://manageiq.org
Apache License 2.0
1.35k stars 900 forks source link

Remove sporadic fix_auth spec pt2 #23216

Closed kbrock closed 1 month ago

kbrock commented 1 month ago

When some encryption keys decode a secret, it looks like they succeed but the end result is garbage.

In specs, when we pick (1) 2 random keys, we area getting these garbage decrypts and it causes a sporadic spec failure

miq-bot commented 1 month ago

Checked commit https://github.com/kbrock/manageiq/commit/44164017d54bf98c4f334cc67812e088015dcec0 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :star:

Fryguy commented 1 month ago

Backported to radjabov in commit 55fafaf2cc2430bd3cd454e95d4791106628b57a.

commit 55fafaf2cc2430bd3cd454e95d4791106628b57a
Author: Jason Frey <fryguy9@gmail.com>
Date:   Tue Oct 1 10:56:16 2024 -0400

    Merge pull request #23216 from kbrock/fix_auth_spec_removal2

    Remove sporadic fix_auth spec pt2

    (cherry picked from commit 5259837b575b431e65ae2dcad72cea60956efc94)