Poll more frequently in Ansible::Runner::ResponseAsync#wait

ManageIQ / manageiq

ManageIQ Open-Source Management Platform

https://manageiq.org

Apache License 2.0

1.35k stars 900 forks source link

Poll more frequently in Ansible::Runner::ResponseAsync#wait #23230

Closed Fryguy closed 1 month ago

Fryguy commented 1 month ago

This method is primarily used by tests, and it was noticed that most of the test cases complete in roughly 0.4s-0.9s in the normal case. Thus, polling more frequently every 0.1s seems to strike a nice balance. With this change, the tests seems to take on average 5s less time.

@agrare Please review.

miq-bot commented 1 month ago

Checked commit https://github.com/Fryguy/manageiq/commit/467e1d5ea98f8e0ac28af511edab16c77c73e728 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :cake: