search

ManageIQ / manageiq

ManageIQ Open-Source Management Platform
https://manageiq.org
Apache License 2.0
1.35k stars 900 forks source link

Update English Translations #23233

Closed miq-bot closed 1 week ago

miq-bot commented 1 month ago

Update the English Translations in the manageiq.po and manageiq.pot files.

Fryguy commented 1 month ago

@jrafanie Does it make sense to change the automated PRs to update the non-english message catalogs, particularly when a string is deleted? The reason that #23218 is failing is because the non-english catalogs still have the old strings, even though they've been deleted in the .pot and the english .po. I was hoping this PR would have those strings removed from the non-english catalogs, but that's not how it works currently.

jrafanie commented 1 month ago

@jrafanie Does it make sense to change the automated PRs to update the non-english message catalogs, particularly when a string is deleted? The reason that #23218 is failing is because the non-english catalogs still have the old strings, even though they've been deleted in the .pot and the english .po. I was hoping this PR would have those strings removed from the non-english catalogs, but that's not how it works currently.

Maybe but that's not how the workflow occurs. We don't ever really merge the non-english po files except from translators. If we remove things in the english pot, it should be removed when the translators apply the changes and provide the updated po files.

miq-bot commented 1 week ago

Checked commit https://github.com/miq-bot/manageiq/commit/f48b1792d387f8c301757e0613ccc15cd4eb3b38 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :cookie:

jrafanie commented 1 week ago

The parent commits that this depends on were already brought back in radjabov.

Fryguy commented 6 days ago

Backported to radjabov in commit 7ddc07b2ee8866bd2f02d3b248b00a9f09228876.

commit 7ddc07b2ee8866bd2f02d3b248b00a9f09228876
Author: Joe Rafaniello <jrafanie@users.noreply.github.com>
Date:   Fri Nov 15 16:49:49 2024 -0500

    Merge pull request #23233 from miq-bot/update_english_translations

    Update English Translations

    (cherry picked from commit 10619c007e16cd4bc28e837fb50c9c007c7ca628)