search

ManageIQ / manageiq

ManageIQ Open-Source Management Platform
https://manageiq.org
Apache License 2.0
1.35k stars 900 forks source link

[WIP] Fix warnings raised by URI 1.0.1 #23261

Open jrafanie opened 2 weeks ago

jrafanie commented 2 weeks ago

WIP:

Related to: https://www.github.com/ruby/uri/issues/125 https://github.com/ManageIQ/manageiq/pull/23260

jrafanie commented 2 weeks ago

@miq-bot cross-repo-tests /all, https://github.com/ManageIQ/manageiq-providers-ovirt/pull/680 https://github.com/ManageIQ/manageiq-providers-vmware/pull/926 https://github.com/ManageIQ/manageiq-gems-pending/pull/596 https://github.com/ManageIQ/manageiq-ui-classic/pull/9307 https://github.com/ManageIQ/vmware_web_service/pull/141 https://github.com/ManageIQ/manageiq-automation_engine/pull/562

jrafanie commented 2 weeks ago

ok, cross repo: https://github.com/ManageIQ/manageiq-cross_repo-tests/pull/928 is green other than an issue requiring qpid_proton in nuage and openstack:

    1) OpenstackStfEventMonitor connecting to STF service URL prepare QDR endpoint
       Failure/Error: require 'qpid_proton'

       ArgumentError:
         wrong number of arguments (given 1, expected 0)
       # ./spec/legacy/events/openstack_stf_event_monitor_spec.rb:5:in `block (2 levels) in <top (required)>'

...

https://github.com/ManageIQ/manageiq-cross_repo-tests/actions/runs/11749197033/job/32736846677?pr=928

    1) ManageIQ::Providers::Nuage::NetworkManager::EventCatcher::Runner .event_monitor_handle
       Failure/Error: require 'qpid_proton'

       ArgumentError:
         wrong number of arguments (given 1, expected 0)
       # ./app/models/manageiq/providers/nuage/network_manager/event_catcher/stream.rb:25:in `initialize'
       # ./app/models/manageiq/providers/nuage/network_manager/event_catcher/runner.rb:7:in `new'
       # ./app/models/manageiq/providers/nuage/network_manager/event_catcher/runner.rb:7:in `event_monitor_handle'
       # ./spec/models/manageiq/providers/nuage/network_manager/event_catcher/runner_spec.rb:12:in `block (2 levels) in <top (required)>'

https://github.com/ManageIQ/manageiq-cross_repo-tests/actions/runs/11749197033/job/32736846113?pr=928

@agrare Have you seen this before?

kbrock commented 2 weeks ago

Looks like legit issues with nuage, openstack: number of args to constructor

jrafanie commented 2 weeks ago

Looks like legit issues with nuage, openstack: number of args to constructor

yeah, thanks, I was meaning to look at those again today

jrafanie commented 2 weeks ago

Looks like legit issues with nuage, openstack: number of args to constructor

I wonder if the warnings about uri 1.0.1 are an indicator it's related to 1.0.1

  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:32: warning: already initialized constant URI::AMQP::DEFAULT_PORT
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:32: warning: previous definition of DEFAULT_PORT was here
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: already initialized constant URI::Schemes::AMQP
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: previous definition of AMQP was here
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:41: warning: already initialized constant URI::AMQPS::DEFAULT_PORT
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:41: warning: previous definition of DEFAULT_PORT was here
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: already initialized constant URI::Schemes::AMQPS
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: previous definition of AMQPS was here
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:32: warning: already initialized constant URI::AMQP::DEFAULT_PORT
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:32: warning: previous definition of DEFAULT_PORT was here
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: already initialized constant URI::Schemes::AMQP
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: previous definition of AMQP was here
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:41: warning: already initialized constant URI::AMQPS::DEFAULT_PORT
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:41: warning: previous definition of DEFAULT_PORT was here
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: already initialized constant URI::Schemes::AMQPS
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: previous definition of AMQPS was here
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:32: warning: already initialized constant URI::AMQP::DEFAULT_PORT
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:32: warning: previous definition of DEFAULT_PORT was here
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: already initialized constant URI::Schemes::AMQP
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: previous definition of AMQP was here
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:41: warning: already initialized constant URI::AMQPS::DEFAULT_PORT
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:41: warning: previous definition of DEFAULT_PORT was here
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: already initialized constant URI::Schemes::AMQPS
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: previous definition of AMQPS was here